After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736763 - Initial set of input sources is wrong when changing locale
Initial set of input sources is wrong when changing locale
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-16 17:38 UTC by Rui Matos
Modified: 2014-09-17 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
language: Emit locale changed signal only after everything else (1.43 KB, patch)
2014-09-16 17:38 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2014-09-16 17:38:48 UTC 
When changing the locale in the first page, the initial set of input
sources that shows up in the second page isn't the appropriate for the
locale chosen.

This happens because the input chooser code checks the current locale
when it gets constructed but it gets the previous locale. See the
patch.
Comment 1 Rui Matos 2014-09-16 17:38:51 UTC 
Created attachment 286314 [details] [review]
language: Emit locale changed signal only after everything else

This signal is used to rebuild all pages and they might want to check
the current language during initialization so we should only emit it
after we set everything.
Comment 2 Matthias Clasen 2014-09-16 23:10:49 UTC 
Review of attachment 286314 [details] [review]:

good catch. please ask for a freeze break
Comment 3 Matthias Clasen 2014-09-17 14:51:55 UTC 
Attachment 286314 [details] pushed as 467e8b9 - language: Emit locale changed signal only after everything else