Created attachment 286056 [details] [review]
sidebar: Set default focus to From entry

Review of attachment 286056 [details] [review]:

::: src/sidebar.js
@@ +86,3 @@
+            if (this.child_revealed)
+                fromEntry.grab_focus();
+        }).bind(this));

couldn't we achieve the same by binding 'child-revealed' to fromEntry.has_focus?

Created attachment 286060 [details] [review]
sidebar: Set default focus to From entry

Review of attachment 286060 [details] [review]:

if you have tested it, ack

Im not convinced.

If from should contain current location dont we want another entry focused? To, or first via?

(In reply to comment #5)
> Im not convinced.
> 
> If from should contain current location dont we want another entry focused? To,
> or first via?

hmm.. true. but its still better than the current situation.

(In reply to comment #5)
> Im not convinced.
> 
> If from should contain current location dont we want another entry focused? To,
> or first via?

I realized that too, but it would be a bit annoying if putting current location in "From" entry wasn't the pretended user action, user will need to go to From manually and tab to a previous widget (Shift+Tab) is not a common and easy action as tab to a next widget. We cannot know the pretended action, we have only one button to meet all routing claims.

If you reveal the sidebar, let's say, by pressing a "From here" button in a bubble or whatever, that's a different situation and I wouldn't set the focus in From.

I leave the patch as "Reviewed" until we agree.