After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736552 - Note color button is the wrong shape
Note color button is the wrong shape
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: UI
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-12 09:11 UTC by Allan Day
Modified: 2015-12-13 20:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (35.18 KB, image/png)
2014-09-12 09:11 UTC, Allan Day 		  Details
Change color button size (591 bytes, patch)
2014-11-26 09:40 UTC, Trinh Anh Ngoc 		committed Details | Review
Screenshot (14.36 KB, image/png)
2015-01-01 09:46 UTC, Trinh Anh Ngoc 		  Details

Description Allan Day 2014-09-12 09:11:59 UTC 
Created attachment 286012 [details]
screenshot

The rest of the buttons are square, but the note color button is a rectangle. They should all be the same shape and size.
Comment 1 Trinh Anh Ngoc 2014-11-26 09:40:51 UTC 
Created attachment 291535 [details] [review]
Change color button size
Comment 2 Pierre-Yves Luyten 2014-11-26 23:19:40 UTC 
Comment on attachment 291535 [details] [review]
Change color button size


> 
> /* Color Button */
>-#define COLOR_SIZE 20
>+#define COLOR_SIZE 22
> 

I'd say 24.

Some better mechanism might probably be found, I think I tried GtkSizeGroup but don't remember exactly the result.
Comment 3 Trinh Anh Ngoc 2015-01-01 09:46:29 UTC 
Created attachment 293549 [details]
Screenshot

Happy New Year
Comment 4 Trinh Anh Ngoc 2015-01-01 09:47:05 UTC 
I'd say 22 :)
Comment 5 Matthias Clasen 2015-01-14 22:35:12 UTC 
should we come do a decision here ?
Comment 6 Andreas Nilsson 2015-11-24 12:00:04 UTC 
I was just about to file a bug about this when I stumbled upon this one.

If the color button is 24 it becomes wider than the button next to it, so I would recommend 22.
Comment 7 Pierre-Yves Luyten 2015-11-29 20:44:32 UTC 
Comment on attachment 291535 [details] [review]
Change color button size

so, its ok for 22

you can push it. if you cannot , please tell me. And sorry for delay!
Comment 8 Trinh Anh Ngoc 2015-11-30 02:12:09 UTC 
Help me push it, thank you.
Comment 9 Pierre-Yves Luyten 2015-12-13 20:55:57 UTC 
Comment on attachment 291535 [details] [review]
Change color button size

commit b1604dc29ef4a76e62fc60a5637d2af571b68ff9