After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736548 - Folder icons for Euronews and The Guardian Videos
Folder icons for Euronews and The Guardian Videos
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-12 08:59 UTC by Allan Day
Modified: 2015-01-20 10:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (373.37 KB, image/png)
2014-09-12 08:59 UTC, Allan Day
Details
euronews logo (9.42 KB, image/svg+xml)
2015-01-16 11:50 UTC, Jakub Steiner
Details
guardian logo (11.78 KB, image/svg+xml)
2015-01-16 11:50 UTC, Jakub Steiner
Details

Description Allan Day 2014-09-12 08:59:32 UTC
Created attachment 286009 [details]
screenshot

The big grey folder icons don't look very good.

Observed with F21 alpha and GNOME 3.13.91 or so.
Comment 1 Bastien Nocera 2014-09-12 09:47:44 UTC
(In reply to comment #0)
> Created an attachment (id=286009) [details]
> screenshot
> 
> The big grey folder icons don't look very good.

Those sources don't have icons (bug 725147). If you have ideas on what to replace the folder with, please let me know, otherwise that's a dupe.
Comment 3 Jakub Steiner 2015-01-16 11:44:18 UTC
Perhaps it would be worth updating the whole aesthetic to be inline with the content loading/failed thumbnails. The giant logos have a certain Makemylogobigger™ feel to it.

Something along these lines -- https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/videos/videos-channels-thumbs.png

The wide nature of the guardian logo might make the sizing a little complicated. I don't think CSS' background-size can actually deal with this case:

- height is 32px
- maximum width is 80% of the container, keeping aspect ratio.
Comment 4 Jakub Steiner 2015-01-16 11:50:07 UTC
Created attachment 294679 [details]
euronews logo
Comment 5 Jakub Steiner 2015-01-16 11:50:27 UTC
Created attachment 294680 [details]
guardian logo
Comment 6 Bastien Nocera 2015-01-20 10:44:33 UTC
commit 936c8154d98abf6168a91e05473cbc0c0538c6de
Author: Bastien Nocera <hadess@hadess.net>
Date:   Tue Jan 20 11:36:55 2015 +0100

    lua-factory: Add local icon for Radio France

commit 5f6ca634c14a15832e69a94d3803cc5b0f9df0e0
Author: Bastien Nocera <hadess@hadess.net>
Date:   Tue Jan 20 11:27:58 2015 +0100

    lua-factory: Add icons for Euronews and Guardian Videos
    
    https://bugzilla.gnome.org/show_bug.cgi?id=736548