After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736512 - Segfault in GtkPlacesSidebar when used with Nautilus
Segfault in GtkPlacesSidebar when used with Nautilus
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2014-09-11 22:57 UTC by Ross Lagerwall
Modified: 2014-09-12 07:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkPlacesSidebar: Only add shortcut if query succeeds (738 bytes, patch)
2014-09-11 22:58 UTC, Ross Lagerwall 		committed Details | Review
GtkPlacesSidebar: Don't update bookmark if cancelled (1.52 KB, patch)
2014-09-11 22:58 UTC, Ross Lagerwall 		committed Details | Review
GtkPlacesSidebar: Fix a memory leak (869 bytes, patch)
2014-09-11 22:58 UTC, Ross Lagerwall 		committed Details | Review

Description Ross Lagerwall 2014-09-11 22:57:16 UTC 
The are a couple segfaults that can occur with Nautilus with the async changes to GtkPlacesSidebar.  Patches coming...
Comment 1 Ross Lagerwall 2014-09-11 22:58:27 UTC 
Created attachment 285959 [details] [review]
GtkPlacesSidebar: Only add shortcut if query succeeds
Comment 2 Ross Lagerwall 2014-09-11 22:58:31 UTC 
Created attachment 285960 [details] [review]
GtkPlacesSidebar: Don't update bookmark if cancelled

If the query fails because it has been cancelled, it means that
dispose() has been called, so don't try and update anything.

This fixes a segfault with Nautilus in certain situations.
Comment 3 Ross Lagerwall 2014-09-11 22:58:35 UTC 
Created attachment 285961 [details] [review]
GtkPlacesSidebar: Fix a memory leak
Comment 4 Emmanuele Bassi (:ebassi) 2014-09-11 23:00:22 UTC 
Review of attachment 285959 [details] [review]:

whoopsie.
Comment 5 Emmanuele Bassi (:ebassi) 2014-09-11 23:01:19 UTC 
Review of attachment 285960 [details] [review]:

looks good.
Comment 6 Emmanuele Bassi (:ebassi) 2014-09-11 23:01:54 UTC 
Review of attachment 285961 [details] [review]:

looks good.
Comment 7 Matthias Clasen 2014-09-12 00:47:19 UTC 
Hi Ross, these look good to push, thanks.
Comment 8 Ross Lagerwall 2014-09-12 07:13:40 UTC 
Pushed to master as ca1e98a..08e1c8e.  Thanks for the reviews.