GNOME Bugzilla – Bug 736508
Outdated glade/vte.xml
Last modified: 2014-09-12 12:11:47 UTC
What's the point of glade/vte.xml.in.in? Seems to contain tons of stuff that were already removed from vte, like background-image, font-antialias, emulation etc. Should we update this file? Or drop it? Drop the complete glade directory? ChPe??
Created attachment 285968 [details] [review] Update some properties Updated some properties. I'm not sure which ones should be present and which ones not, i.e. how about hadjustment, vadjustment, hscroll-policy, vscroll-policy, current-directory-uri, current-file-uri; should these be added too?
If glade still supports catalogues, then yes, vte's should be updated for the changes in the 2.91 API. Read-only properties like current-*-uri shouldn't be listed, of course.
> Read-only properties like current-*-uri shouldn't be listed, of course. Why "of course"? (Read: I don't know what glade does with this file. I guess it helps you building a vte-based app by clicking together a UI and connecting stuff here and there... but shouldn't you be able to connect something to when a read-only value changes? I'm just making wild guesses.) icon/window-title are read-only properties, but are listed currently. Scrollbar properties are defined like this g_object_class_override_property (gobject_class, PROP_HADJUSTMENT, "hadjustment"); rather than with g_object_class_install_property as the rest, how do I know if they're read-only?
Oh hrm. I though that those properties lists were only used to be able to set properties, didn't think about notify::foo signals... so might make sense to include them. (Not sure glade needs this for signal connections, don't have a glade build right now to check.) For the 2nd question, you can check if vte_terminal_set_property handles them; if so they're writeable.
Added all of them for now. Will remove the read-only ones later if they cause problems.