After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736496 - Suspicious usage of i.e in gschema string
Suspicious usage of i.e in gschema string
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
unspecified
Other All
: Normal minor
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-11 18:20 UTC by Anders Jonsson
Modified: 2014-11-22 09:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use e.g. rather than i.e. (793 bytes, patch)
2014-09-11 20:38 UTC, Anders Jonsson 		committed Details | Review

Description Anders Jonsson 2014-09-11 18:20:50 UTC 
Hi,

I noticed the following gschema string in gnome-clocks:

"State of the window: i.e. maximized."


Here I suspect that it is "e.g." ("for example") that is the intended abbreviation rather than "i.e." ("that is"). As the string stands now with "i.e.", it means that the window state is "maximized" whenever one looks at the gschema string.
Comment 1 Paolo Borelli 2014-09-11 19:32:19 UTC 
yeah, the whole string could be better. Anyway it is just the comment for a setting, not worth breaking string freeze now, let's fix it next cycle.

A patch would be still very welcome :)
Comment 2 Anders Jonsson 2014-09-11 20:38:44 UTC 
Created attachment 285951 [details] [review]
Use e.g. rather than i.e.

Here is a patch for next development cycle.

This uses e.g. rather than i.e., and replaces the colon with a comma.
Comment 3 Anders Jonsson 2014-11-21 20:09:36 UTC 
(In reply to comment #1)
> yeah, the whole string could be better. Anyway it is just the comment for a
> setting, not worth breaking string freeze now, let's fix it next cycle.
> 
> A patch would be still very welcome :)

Ping. We're in the 3.16 cycle now, so if you could apply the patch in comment 2 it would be great :-)
Comment 4 Paolo Borelli 2014-11-22 09:14:46 UTC 
pushed, thank you