After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736470 - Include screenshot-window-sizer extension
Include screenshot-window-sizer extension
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-11 12:46 UTC by Florian Müllner
Modified: 2014-09-17 05:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot-window-sizer: New extension (10.08 KB, patch)
2014-09-11 12:46 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-09-11 12:46:50 UTC 
See patch - with Software gaining traction, making it easier for maintainers to take screenshots of their applications looks like a good reason to me to move this into our set of officially supported extensions.
(Might be late for this cycle though, even without translatable strings that would require a string break ...)
Comment 1 Florian Müllner 2014-09-11 12:46:55 UTC 
Created attachment 285903 [details] [review]
screenshot-window-sizer: New extension

Originally from hughsie's github[0], but way too useful to leave
in a 3rd party repo :-)

[0] https://github.com/hughsie/gnome-shell-extension-screenshot-window-sizer
Comment 2 drago01 2014-09-14 09:04:17 UTC 
Review of attachment 285903 [details] [review]:

I agree that we should add this one. The code looks good to me just two small things.

::: extensions/screenshot-window-sizer/extension.js
@@ +35,3 @@
+function hideMessage() {
+    Main.uiGroup.remove_actor(text);
+    text = null;

Is that enough to free the memory? I'd do text.destroy() before setting it to null.

@@ +55,3 @@
+    Tweener.addTween(text,
+                     { opacity: 0,
+                       time: 2,

Should be a constant.
Comment 3 Florian Müllner 2014-09-17 05:18:25 UTC 
Attachment 285903 [details] pushed as 1d5ab0f - screenshot-window-sizer: New extension