After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736463 - put scrollbar to the right
put scrollbar to the right
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.13.x
Other Linux
: Low minor
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-11 10:09 UTC by Jakub Steiner
Modified: 2016-02-02 13:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
awkward scrollbar in the middle (812.33 KB, image/png)
2014-09-11 10:09 UTC, Jakub Steiner 		  Details
Scrollbar-position-fix (1.77 KB, patch)
2016-02-01 16:08 UTC, Saiful B. Khan 		rejected Details | Review
Unnecessary dead code removed. (949 bytes, patch)
2016-02-02 08:57 UTC, Saiful B. Khan 		none Details | Review
Repositioned scroll bar in search view (1.67 KB, patch)
2016-02-02 13:28 UTC, Saiful B. Khan 		committed Details | Review

Description Jakub Steiner 2014-09-11 10:09:38 UTC 
Created attachment 285898 [details]
awkward scrollbar in the middle

I like the improved fixed width layout of the search result page, yet having the scrollbar adjacent to the content box feels really awkward. The scrollbar should remain on the window edge, with the content kept in the middle.
Comment 1 Saiful B. Khan 2016-02-01 16:08:48 UTC 
Created attachment 320188 [details] [review]
Scrollbar-position-fix
Comment 2 Felipe Borges 2016-02-02 08:44:38 UTC 
Review of attachment 320188 [details] [review]:

Thanks for your patch.

--- a/gnomemusic/view.py
+++ b/gnomemusic/view.py
@@ -1341,8 +1341,8 @@ class Search(ViewContainer):
     @log
     def __init__(self, window, player):
         ViewContainer.__init__(self, 'search', None, window, Gd.MainViewType.LIST)
-        self.view.set_halign(Gtk.Align.CENTER)
-        self.view.set_size_request(530, -1)
+        #self.view.set_halign(Gtk.Align.CENTER)
+        #self.view.set_size_request(530, -1)

Could you please remove this commented lines? We don't want dead code within the source.
Comment 3 Saiful B. Khan 2016-02-02 08:57:05 UTC 
Created attachment 320252 [details] [review]
Unnecessary dead code removed.
Comment 4 Saiful B. Khan 2016-02-02 13:26:15 UTC 
Ignore the last patch (incomplete).
Comment 5 Saiful B. Khan 2016-02-02 13:28:38 UTC 
Created attachment 320264 [details] [review]
Repositioned scroll bar in search view

This fix removes the dead code present in the last reviewed patch.
Comment 6 Felipe Borges 2016-02-02 13:40:31 UTC 
Review of attachment 320264 [details] [review]:

Sure.