After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736460 - mpegpsmux: refactor duplicate else branches
mpegpsmux: refactor duplicate else branches
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.x
Other Linux
: Normal trivial
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-11 09:21 UTC by Anuj
Modified: 2014-09-23 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mpegpsmux: refactor duplicate else branches (879 bytes, patch)
2014-09-11 09:21 UTC, Anuj 		none Details | Review
mpegpsmux: refactor duplicate else branches (879 bytes, patch)
2014-09-11 09:25 UTC, Anuj 		needs-work Details | Review
g_assert_not_reached() (990 bytes, patch)
2014-09-23 16:39 UTC, Luis de Bethencourt 		committed Details | Review

Description Anuj 2014-09-11 09:21:46 UTC 
Created attachment 285895 [details] [review]
mpegpsmux: refactor duplicate else branches

gst-plugin-bad/gst/mpegpsmux: there are duplicate branches of else in psmuxstream.c file, please review.
Comment 1 Anuj 2014-09-11 09:25:08 UTC 
Created attachment 285896 [details] [review]
mpegpsmux: refactor duplicate else branches
Comment 2 Tim-Philipp Müller 2014-09-11 09:40:58 UTC 
Not convinced this is a worthwhile change. If we remove the value for the unknown case there really should be an else g_assert_not_reached() then or so, to make sure things are still set up properly if someone adds subtitle support in future, for example. I'd suggest to just leave it as is.
Comment 3 Sebastian Dröge (slomo) 2014-09-12 12:56:11 UTC 
Comment on attachment 285896 [details] [review]
mpegpsmux: refactor duplicate else branches

Yes, let's add a g_assert_not_reached() there.
Comment 4 Luis de Bethencourt 2014-09-23 16:39:03 UTC 
Created attachment 286896 [details] [review]
g_assert_not_reached()

As proposed.
Comment 5 Luis de Bethencourt 2014-09-23 16:59:26 UTC 
Review of attachment 286896 [details] [review]:

commited