GNOME Bugzilla – Bug 736433
Wire keymap changes up to the wayland frontend
Last modified: 2014-09-11 17:09:12 UTC
The first patch isn't really related but it's needed anyway otherwise the code in gnome-shell around input source switching makes us crash when running native.
Created attachment 285846 [details] [review] keybindings: Freeze and ungrab the keyboard only on X11 backend This isn't needed in the native backend because we control all the input event flow there.
Created attachment 285847 [details] [review] wayland-keyboard: Handle keymap-changed signal We need to inform wayland clients of new keymaps.
Created attachment 285848 [details] [review] backends: Add a keymap-layout-group-changed signal We'll need this in the wayland frontend to send a modifiers event to clients.
Created attachment 285849 [details] [review] wayland-keyboard: Handle keymap-layout-group-changed signal We need to send a modifiers event to wayland clients when the layout group changes.
Review of attachment 285846 [details] [review]: OK.
Review of attachment 285847 [details] [review]: ::: src/wayland/meta-wayland-keyboard.c @@ +214,3 @@ + + meta_wayland_keyboard_take_keymap (keyboard, + meta_backend_get_keymap (backend)); Put this all on one line. @@ +371,2 @@ meta_wayland_keyboard_take_keymap (keyboard, + meta_backend_get_keymap (backend)); Same here.
Review of attachment 285848 [details] [review]: Do we not want an implementation of this under X11?
Review of attachment 285849 [details] [review]: Makes sense to me.
Created attachment 285925 [details] [review] wayland-keyboard: Handle keymap-changed signal -- Fixed the broken lines.
Created attachment 285926 [details] [review] backends: Add a keymap-layout-group-changed signal We'll need this in the wayland frontend to send a modifiers event to clients. Note that on X11 this isn't needed because key events include the group index encoded in modifier state. If we ever want to make the wayland frontend work with the X11 backend we'll handle it then. -- (In reply to comment #7) > Do we not want an implementation of this under X11? See the expanded commit message above.
(In reply to comment #10) > Created an attachment (id=285926) [details] [review] > backends: Add a keymap-layout-group-changed signal > > We'll need this in the wayland frontend to send a modifiers event to > clients. > > Note that on X11 this isn't needed because key events include the > group index encoded in modifier state. If we ever want to make the > wayland frontend work with the X11 backend we'll handle it then. That's what nested --wayland mode is. I'm fine with omitting some of the trickier parts of input sources / keyboard though, I guess.
Review of attachment 285925 [details] [review]: OK.
Review of attachment 285926 [details] [review]: LG.
Attachment 285846 [details] pushed as 6ba0491 - keybindings: Freeze and ungrab the keyboard only on X11 backend Attachment 285849 [details] pushed as 656573c - wayland-keyboard: Handle keymap-layout-group-changed signal Attachment 285925 [details] pushed as 5309242 - wayland-keyboard: Handle keymap-changed signal Attachment 285926 [details] pushed as 59c5ac0 - backends: Add a keymap-layout-group-changed signal