After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736422 - pep8 complains about d-feet source code
pep8 complains about d-feet source code
Status: RESOLVED FIXED
Product: d-feet
Classification: Other
Component: general
0.3.x
Other Linux
: Normal normal
: ---
Assigned To: D-Feet Maintainer(s)
D-Feet Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-10 14:59 UTC by Marcos Marado
Modified: 2014-10-11 07:30 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Marcos Marado 2014-09-10 14:59:26 UTC
running d-feet source through pep8 gets this result:

src/dfeet/addconnectiondialog.py:13:9: E265 block comment should start with '# '
src/dfeet/addconnectiondialog.py:24:9: E265 block comment should start with '# '
src/dfeet/addconnectiondialog.py:46:13: E265 block comment should start with '# '
src/dfeet/application.py:18:5: E265 block comment should start with '# '
src/dfeet/application.py:22:5: E265 block comment should start with '# '
src/dfeet/application.py:28:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:25:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:27:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:31:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:35:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:39:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:41:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:51:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:59:13: E265 block comment should start with '# '
src/dfeet/bus_watch.py:97:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:111:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:120:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:125:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:131:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:133:13: E265 block comment should start with '# '
src/dfeet/bus_watch.py:136:13: E265 block comment should start with '# '
src/dfeet/bus_watch.py:145:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:149:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:153:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:157:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:165:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:170:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:187:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:196:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:200:13: E265 block comment should start with '# '
src/dfeet/bus_watch.py:235:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:243:13: E265 block comment should start with '# '
src/dfeet/bus_watch.py:252:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:253:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:256:13: E265 block comment should start with '# '
src/dfeet/bus_watch.py:259:13: E265 block comment should start with '# '
src/dfeet/bus_watch.py:262:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:268:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:287:13: E265 block comment should start with '# '
src/dfeet/bus_watch.py:303:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:305:9: E265 block comment should start with '# '
src/dfeet/bus_watch.py:316:9: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:40:9: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:45:9: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:55:13: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:71:17: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:78:17: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:80:17: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:81:17: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:82:17: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:83:17: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:86:13: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:93:13: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:95:13: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:99:13: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:108:13: E265 block comment should start with '# '
src/dfeet/executemethoddialog.py:116:13: E265 block comment should start with '# '
src/dfeet/introspection.py:41:9: E265 block comment should start with '# '
src/dfeet/introspection.py:56:9: E265 block comment should start with '# '
src/dfeet/introspection.py:59:13: E265 block comment should start with '# '
src/dfeet/introspection.py:75:13: E265 block comment should start with '# '
src/dfeet/introspection.py:86:9: E265 block comment should start with '# '
src/dfeet/introspection.py:99:13: E265 block comment should start with '# '
src/dfeet/introspection.py:104:13: E265 block comment should start with '# '
src/dfeet/introspection.py:113:13: E265 block comment should start with '# '
src/dfeet/introspection.py:115:13: E265 block comment should start with '# '
src/dfeet/introspection.py:157:9: E265 block comment should start with '# '
src/dfeet/introspection.py:159:9: E265 block comment should start with '# '
src/dfeet/introspection.py:171:13: E265 block comment should start with '# '
src/dfeet/introspection.py:177:13: E265 block comment should start with '# '
src/dfeet/introspection.py:179:13: E265 block comment should start with '# '
src/dfeet/introspection.py:184:17: E265 block comment should start with '# '
src/dfeet/introspection.py:186:17: E265 block comment should start with '# '
src/dfeet/introspection.py:194:21: E265 block comment should start with '# '
src/dfeet/introspection.py:203:21: E265 block comment should start with '# '
src/dfeet/introspection.py:212:21: E265 block comment should start with '# '
src/dfeet/introspection.py:221:21: E265 block comment should start with '# '
src/dfeet/introspection.py:231:13: E265 block comment should start with '# '
src/dfeet/introspection.py:234:17: E112 expected an indented block
src/dfeet/introspection.py:234:17: E265 block comment should start with '# '
src/dfeet/introspection.py:240:17: E265 block comment should start with '# '
src/dfeet/introspection.py:243:17: E265 block comment should start with '# '
src/dfeet/introspection.py:251:9: E265 block comment should start with '# '
src/dfeet/introspection.py:254:9: E265 block comment should start with '# '
src/dfeet/settings.py:8:5: E265 block comment should start with '# '
src/dfeet/settings.py:11:5: E265 block comment should start with '# '
src/dfeet/uiloader.py:36:9: E265 block comment should start with '# '
src/dfeet/window.py:45:9: E265 block comment should start with '# '
src/dfeet/window.py:49:9: E265 block comment should start with '# '
src/dfeet/window.py:62:9: E265 block comment should start with '# '
src/dfeet/window.py:68:9: E265 block comment should start with '# '
src/dfeet/window.py:78:9: E265 block comment should start with '# '
src/dfeet/window.py:84:9: E265 block comment should start with '# '
src/dfeet/wnck_utils.py:36:20: E713 test for membership should be 'not in'
src/dfeet/wnck_utils.py:46:17: E113 unexpected indentation
src/dfeet/wnck_utils.py:47:17: E113 unexpected indentation
src/dfeet/wnck_utils.py:50:12: E713 test for membership should be 'not in'
src/dfeet/wnck_utils.py:55:12: E713 test for membership should be 'not in'
src/tests/tests.py:69:9: E265 block comment should start with '# '
src/tests/tests.py:101:9: E265 block comment should start with '# '
src/tests/tests.py:102:9: E265 block comment should start with '# '
src/tests/tests.py:106:5: E265 block comment should start with '# '

These are all trivially fixed, here's a patch:
https://github.com/marado/d-feet/commit/47a8373580d2f1b9f931ab231b0318ed0f44c39b
Comment 1 Thomas Bechtold 2014-10-11 07:30:03 UTC
Thanks Marcos for the patch. Applied.