GNOME Bugzilla – Bug 736421
dashdemux: improve detection of the position on download restart
Last modified: 2014-09-11 21:33:16 UTC
Query other src pads before falling back to the position of the last known pushed segment (which can be far ahead in time).
Created attachment 285827 [details] [review] dashdemux: improve position detection when a download restart
Created attachment 285859 [details] [review] mssdemux: improve position detection when a download restart The same patch is appliable to mssdemux, attached it. hlsdemux doesn't need as it only has one output pad for now. But before merging, I'd like to know why/where does the pad query fail to see if we can fix that. Can you get a log with it failing?
(In reply to comment #2) > Created an attachment (id=285859) [details] [review] > mssdemux: improve position detection when a download restart > > The same patch is appliable to mssdemux, attached it. > > hlsdemux doesn't need as it only has one output pad for now. > > But before merging, I'd like to know why/where does the pad query fail to > see if we can fix that. Can you get a log with it failing? It was failing on a custom pipeline involving proprietary decoder elements. For some reasons we couldn't trust some of the decoders (the audio ones) and have to disable the position query on thoses ones (and only the video decoder can be trusted).
commit bce21e73982ed476a1d4ecd73007ba382a4510f3 Author: Matthieu Bouron <matthieu.bouron@collabora.com> Date: Wed Sep 10 15:39:44 2014 -0300 mssdemux: improve position detection when a download restart Query other src pads before falling back to the position of the last known pushed segment (which can be far ahead in time). https://bugzilla.gnome.org/show_bug.cgi?id=736421 commit 4ed7c7919a2659d24e5450d2dd8cc927dd47bb2e Author: Matthieu Bouron <matthieu.bouron@collabora.com> Date: Wed Sep 10 15:43:05 2014 +0200 dashdemux: improve position detection when a download restart Query other src pads before falling back to the position of the last known pushed segment (which can be far ahead in time). https://bugzilla.gnome.org/show_bug.cgi?id=736421