GNOME Bugzilla – Bug 736408
find popup is 'floating'
Last modified: 2014-09-11 15:53:09 UTC
it just floats over content, which looks irritating. Compare to gedit, which has a very similar popup, but it has a white box around it that 'anchors' it to the top.
Created attachment 285837 [details] [review] add some styling to the find revealer The attached path styles the find revealer in the same way as done in gedit. It just uses some in-line CSS, as I could not find any other CSS in Yelp to add the overrides to.
Created attachment 285839 [details] floating find entry
Created attachment 285840 [details] find entry with styling fixes in patch
Yeah, now I remember not finishing this. I think I remember digging through Adwaita's CSS looking for a style class to use and couldn't find one. I'm surprised I need to add custom CSS for this.
Border color is kind of dark. Darker than gedit's.
Created attachment 285867 [details] yelp and gedit find bars I do not think that it is too surprising that custom CSS is required, as the revealer is only for animating the display of a widget. It does not draw a background, and neither does a box, which is what the entry and buttons were packed into. If you remove the CSS, and are left with the GtkFrame, the result is pretty ugly. The CSS was copied from gedit (master, of course, so you might not be familiar with all the Adwaita changes that have happened recently). :-)
If it's a design pattern we expect developers to use, then I would expect a common CSS class. We have plenty of classes we use to style otherwise-generic widgets to create looks we want. Your gedit looks different than mine, but I'm not running gedit from master. If that's what it looks like now, then I guess they match.
I think that the expected widget for this design pattern would be GtkSearchBar. Yelp already uses that, for a different purpose (searching for a document rather than within a document), and the same widget is also used by other applications such as Epiphany, Logs, Boxes and so on. There are a few applications, such as Evince, that have a custom (but similar-looking) widget to accomplish a similar task. Although Yelp does not quite fit into the typical GNOME 3 application mould, the HIG has a page on search: https://git.gnome.org/browse/gnome-devel-docs/tree/hig/C/search.page which suggests a similar approach (search bar sliding in from under the header bar). I think that it is reasonable to present Yelp's search and find functionality differently, and it seems natural to try to match the styling to that of another GNOME application such as gedit. A new widget or style class could come later, if enough applications want to follow the same design pattern, but it seems that one search pattern is enough to cover the majority of cases. Anyway, not to push too much, but the patch will need a UI freeze break exception, so it would be good to get a yay/nay and then (hopefully) proceed to get the necessary release team approvals before Monday, in time for the 3.13.92 release.
Oh, I'm fine with the patch. I was just making general commentary on why it's in the state it is. I didn't realize we're already in UI freeze.
Comment on attachment 285837 [details] [review] add some styling to the find revealer Pushed to master with release team approval: https://mail.gnome.org/archives/release-team/2014-September/msg00048.html