After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736403 - Don't try to remove non-existent timeout source
Don't try to remove non-existent timeout source
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: librygel-server
0.22.x
Other All
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-10 10:34 UTC by Debarshi Ray
Modified: 2014-09-10 13:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dbus-thumbnailer: Don't try to remove non-existent timeout source (898 bytes, patch)
2014-09-10 10:36 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-09-10 10:34:38 UTC 
In rygel-dbus-thumbnailer.vala, queue_thumbnail_task does not reset this.timeout_id when removing it. At that point, if we have exceeded the maximum queue size and this.tumbler is null, then this.timeout_id will continue to hold the old value.

Let's always reset this.timeout_id after removing it.
Comment 1 Debarshi Ray 2014-09-10 10:36:19 UTC 
Created attachment 285814 [details] [review]
dbus-thumbnailer: Don't try to remove non-existent timeout source
Comment 2 Jens Georg 2014-09-10 12:36:49 UTC 
Review of attachment 285814 [details] [review]:

+1
Comment 3 Debarshi Ray 2014-09-10 13:23:05 UTC 
Comment on attachment 285814 [details] [review]
dbus-thumbnailer: Don't try to remove non-existent timeout source

Thanks for the quick review!