After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736369 - Smileys are not centered ("Insert Smiley" menu)
Smileys are not centered ("Insert Smiley" menu)
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
3.12.x
Other Linux
: Normal trivial
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-10 01:20 UTC by Kevin Haller
Modified: 2014-09-12 07:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Current "Insert Smiley" menu (31.40 KB, image/png)
2014-09-10 01:20 UTC, Kevin Haller 		  Details
Patch: Center smileys inside the menu item (2.07 KB, patch)
2014-09-10 01:40 UTC, Kevin Haller 		reviewed Details | Review
After patch: "Insert Smiley" menu (31.29 KB, image/png)
2014-09-10 01:44 UTC, Kevin Haller 		  Details
Patch: Center smileys inside the menu item 02 (1.73 KB, patch)
2014-09-11 21:11 UTC, Kevin Haller 		committed Details | Review

Description Kevin Haller 2014-09-10 01:20:27 UTC 
Created attachment 285781 [details]
Current "Insert Smiley" menu

The image of the smiley inside the menu item is left-justified. (see attachment)
Comment 1 Kevin Haller 2014-09-10 01:40:47 UTC 
Created attachment 285782 [details] [review]
Patch: Center smileys inside the menu item
Comment 2 Kevin Haller 2014-09-10 01:44:22 UTC 
Created attachment 285785 [details]
After patch: "Insert Smiley" menu
Comment 3 Guillaume Desmottes 2014-09-11 08:40:06 UTC 
Hi Kevin, thanks for your patch.
Would it be possible to achieve the same result using Gtk's CSS engine instead? 
We are trying to move style related settings to empathy.css.

Btw, our coding style are "MACRO (arg)" not "MACRO(arg)".
Comment 4 Kevin Haller 2014-09-11 21:11:49 UTC 
Created attachment 285953 [details] [review]
Patch: Center smileys inside the menu item 02

Hi

I think a pure CSS solution is not possible ...

#GtkImage must be added manually to the #GtkMenuItem (a label can be added per default, but afaik a #GtkLabel cannot display images). 

..., but to set a 'style name' for the GtkMenuItem. 

enclosed the patch with the modified code.
Comment 5 Guillaume Desmottes 2014-09-12 07:41:37 UTC 
Thanks, I changed your patch to use CSS class instead (cleaner) and pushed it
to master.