After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736363 - ephy-location-entry: update padding for latest Adwaita
ephy-location-entry: update padding for latest Adwaita
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-09 22:10 UTC by Michael Catanzaro
Modified: 2015-07-05 18:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ephy-location-entry: update padding for latest Adwaita (988 bytes, patch)
2014-09-09 22:10 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-09-09 22:10:30 UTC 
In Epiphany 3.10 the URL in our completions is aligned nicely with the URL in the location entry, but it looks like the location entry URL is farther to the right in master.
Comment 1 Michael Catanzaro 2014-09-09 22:10:32 UTC 
Created attachment 285776 [details] [review]
ephy-location-entry: update padding for latest Adwaita

Our code for aligning the URL of completions with the URL in the
location entry seems to be theme-dependent, and the alignment isn't
quite right with the latest Adwaita.
Comment 2 Carlos Garcia Campos 2014-09-10 12:25:15 UTC 
Comment on attachment 285776 [details] [review]
ephy-location-entry: update padding for latest Adwaita

So, this will break when using previous versions of the theme?
Comment 3 Michael Catanzaro 2014-09-10 12:43:03 UTC 
Probably yes. If you're using older GTK+ and this patch makes the alignment worse, then definitely yes. I don't think this code is likely to be correct except for the particular version of Adwaita it was written for.
Comment 4 Michael Catanzaro 2015-03-02 14:17:07 UTC 
I think we should push this patch as-is since the new hardcoded value is clearly not worse than the previous hardcoded value.
Comment 5 Claudio Saavedra 2015-03-03 14:42:05 UTC 
Works for me.
Comment 6 Michael Catanzaro 2015-07-05 18:11:35 UTC 
Attachment 285776 [details] pushed as 8946481 - ephy-location-entry: update padding for latest Adwaita