GNOME Bugzilla – Bug 736338
GTK+ reftests can't be built on W32
Last modified: 2014-09-22 13:50:37 UTC
due to libreftest depending on gtk-reftest
Created attachment 285746 [details] [review] Make reftest plugins W32-compatible When a plugin is loaded, see if it has an initialization function. If it does, call that function, passing snapshot API function table to it. This way reftest plugins can be built without linking them to gtk-reftest application (which provides snapshot inhibition API).
Review of attachment 285746 [details] [review]: See minor nitpicks ::: testsuite/reftests/libreftest.h @@ +1,2 @@ +/* GTK - The GIMP Toolkit + * Copyright (C) 2014 Red Hat, Inc. this is done by you no? @@ +30,3 @@ + reftest_inhibit_snapshot_func reftest_inhibit_snapshot; + reftest_uninhibit_snapshot_func reftest_uninhibit_snapshot; +} reftest_api; I do not like much the name but at worst it should be ReftestAPI
Did a bunch of refactoring to arrive at a better waqy to handle this. Unfortunately it didn't make 3.14.0, but it will be in 3.14.1. https://git.gnome.org/browse/gtk+/commit/?id=9d0ec409ff8579d5ac33bd522c40f6e3a945d152 is the patch needed on top of 3.14.0 to make it work.