After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736338 - GTK+ reftests can't be built on W32
GTK+ reftests can't be built on W32
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-09-09 15:16 UTC by LRN
Modified: 2014-09-22 13:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make reftest plugins W32-compatible (7.52 KB, patch)
2014-09-09 15:17 UTC, LRN
needs-work Details | Review

Description LRN 2014-09-09 15:16:56 UTC
due to libreftest depending on gtk-reftest
Comment 1 LRN 2014-09-09 15:17:03 UTC
Created attachment 285746 [details] [review]
Make reftest plugins W32-compatible

When a plugin is loaded, see if it has an initialization function.
If it does, call that function, passing snapshot API function table to it.
This way reftest plugins can be built without linking them to gtk-reftest
application (which provides snapshot inhibition API).
Comment 2 Ignacio Casal Quinteiro (nacho) 2014-09-10 07:14:01 UTC
Review of attachment 285746 [details] [review]:

See minor nitpicks

::: testsuite/reftests/libreftest.h
@@ +1,2 @@
+/* GTK - The GIMP Toolkit
+ * Copyright (C) 2014 Red Hat, Inc.

this is done by you no?

@@ +30,3 @@
+  reftest_inhibit_snapshot_func   reftest_inhibit_snapshot;
+  reftest_uninhibit_snapshot_func reftest_uninhibit_snapshot;
+} reftest_api;

I do not like much the name but at worst it should be ReftestAPI
Comment 3 Benjamin Otte (Company) 2014-09-22 13:50:37 UTC
Did a bunch of refactoring to arrive at a better waqy to handle this. Unfortunately it didn't make 3.14.0, but it will be in 3.14.1.

https://git.gnome.org/browse/gtk+/commit/?id=9d0ec409ff8579d5ac33bd522c40f6e3a945d152 is the patch needed on top of 3.14.0 to make it work.