After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736303 - [PATCH] Use set_accels_for_action().
[PATCH] Use set_accels_for_action().
Status: RESOLVED FIXED
Product: gnome-mines
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-mines-maint
gnome-mines-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-09 03:55 UTC by Arnaud B.
Modified: 2014-09-10 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use set_accels_for_action(). (1.28 KB, patch)
2014-09-09 03:55 UTC, Arnaud B. 		committed Details | Review

Description Arnaud B. 2014-09-09 03:55:41 UTC 
Created attachment 285703 [details] [review]
Use set_accels_for_action().

As add_accelerator() is deprecated…
Comment 1 Robert Roth 2014-09-10 04:28:38 UTC 
@Michael Catanzaro: any specific reason why you've reviewed the patch with commit after freeze? We're still before hard code freeze, and this patch doesn't have string changes or feature changes, I don't see why this couldn't be committed before 3.13.92.
Comment 2 Michael Catanzaro 2014-09-10 12:21:34 UTC 
You can commit it!  It's harmless, but I've pushed plenty of "harmless" patches before and we're getting pretty close to 3.14, so I'm personally only pushing changes that fix bugs at this point.  I figure you'll notice if accelerators in Mines stop working, but I won't notice if accelerators in one out of 16 games break.
Comment 3 Robert Roth 2014-09-10 17:43:32 UTC 
Attachment 285703 [details] pushed as 22dd0bc - Use set_accels_for_action().