After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736301 - [PATCH] Use set_accels_for_action().
[PATCH] Use set_accels_for_action().
Status: RESOLVED FIXED
Product: gnome-klotski
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-klotski-maint
gnome-klotski-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-09 03:41 UTC by Arnaud B.
Modified: 2014-09-21 23:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Bump Gtk+ required version to 3.12.0. (647 bytes, patch)
2014-09-09 03:41 UTC, Arnaud B. 		committed Details | Review
Use set_accels_for_action(). (1.35 KB, patch)
2014-09-09 03:42 UTC, Arnaud B. 		committed Details | Review
Require vala 0.24 (636 bytes, patch)
2014-09-21 23:46 UTC, Michael Catanzaro 		committed Details | Review

Description Arnaud B. 2014-09-09 03:41:56 UTC 
Created attachment 285700 [details] [review]
Bump Gtk+ required version to 3.12.0.

As add_accelerator() is deprecated…

The first patch is to bump Gtk required version to 3.12.0, as it has been added in this cycle.
Comment 1 Arnaud B. 2014-09-09 03:42:35 UTC 
Created attachment 285701 [details] [review]
Use set_accels_for_action().
Comment 2 Michael Catanzaro 2014-09-09 03:55:56 UTC 
Review of attachment 285701 [details] [review]:

What could possibly go wrong!
Comment 3 Michael Catanzaro 2014-09-09 03:56:11 UTC 
Review of attachment 285700 [details] [review]:

Yup.
Comment 4 Michael Catanzaro 2014-09-21 23:46:52 UTC 
Created attachment 286764 [details] [review]
Require vala 0.24

For set_accels_for_action
Comment 5 Michael Catanzaro 2014-09-21 23:47:49 UTC 
Attachment 285701 [details] pushed as 7ef9244 - Use set_accels_for_action().
Attachment 286764 [details] pushed as 28e61bd - Require vala 0.24