GNOME Bugzilla – Bug 736284
Keep only one list of signal emissions
Last modified: 2014-10-12 00:00:59 UTC
While looking through glib for uses of G_HAVE_GROWING_STACK to get rid of it to simplify cross-compiling I found only this one. It doesn't seem to be necessary to differentiate between those 2 types of signals, so I simplified the code. I found out later that G_HAVE_GROWING_STACK is public API (yay!). Fwiw what the code is doing in the first place is only correct in single-threaded signal emissions as there is no guarantee that the thread emitting the signal first is having its stack in a lower/higher memory area. But I guess nobody ever emits the same signal on the same object twice from different threads anyway...
Created attachment 285671 [details] [review] signal: Keep only one list of emissions There is no need to keep 2 lists. This simplifies the code and gets rid of the only user inside glib of G_HAVE_GROWING_STACK.
Looks good and is a nice simplification.
Comment on attachment 285671 [details] [review] signal: Keep only one list of emissions I more or less accidentally pushed this patch to master. Which kinda means I had accidentally been using this patch for the last months. So I'll eave it in unless somebody wants it back out, then go revert it and reopen this bug.