After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736241 - Prefer embedded album art over downloaded
Prefer embedded album art over downloaded
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.14.x
Other Linux
: Normal enhancement
: 3.14
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-07 21:25 UTC by Piotr Pyclik
Modified: 2014-10-03 11:55 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Piotr Pyclik 2014-09-07 21:25:29 UTC
Right now, Music ignores cover art embedded in music files and always downloads it with Grilo. It would be more logical, to prefer cover art embedded in files or saved in the music directory (i.e. cover.* files) and download cover art only, if it is not present locally. It is rational to assume, that user wants to see cover art, that he had picked and embedded into music files and see downloaded art only, if embedded art is absent. Also, cover art could not always be found (leaving placeholder images) and seems to be of mixed quality.
Comment 1 Vadim Rutkovsky 2014-09-09 06:51:14 UTC
This is handled by grilo plugin and should be handled there
Comment 2 Juan A. Suarez Romero 2014-09-12 07:56:58 UTC
The priority of each plugin can be defined through its rank, which is just a number that defines the priority of that plugin over others.

Applications can set up the ranks they wish for the plugins. And the users also can set up the ranks through environment variable (https://developer.gnome.org/grilo/unstable/ch02.html).


By default, all the plugins have the same rank. Probably this should be changed, and for instance give more priority to plugins that don't go to Internet than those that do.
Comment 3 Vadim Rutkovsky 2014-10-03 11:55:39 UTC
I've pushed (In reply to comment #2)
> The priority of each plugin can be defined through its rank, which is just a
> number that defines the priority of that plugin over others.
Ah, great, thanks!

I've pushed some commits to master, so this should be fixed:
master https://git.gnome.org/browse/gnome-music/commit/?id=9f24e770c334cadd67b2a5ccaffe27b3085f729f
gnome-3-14 https://git.gnome.org/browse/gnome-music/commit/?h=gnome-3-14&id=8952791947556058bcc40709a76d5142fb6974ac