GNOME Bugzilla – Bug 736237
Please enable orca autostart on XFCE, LXDE, MATE
Last modified: 2014-09-11 18:39:23 UTC
Hello, orca-autostart.desktop.in is currently enabled only for gnome and Unity, so as to avoid starting orca in KDE (where it is completely useless ATM). XFCE, LXDE and MATE are however at least somewhat accessible, so it would be good to enable autostart there too. I don't know about the other XDG desktops. I have attached a proposed patch.
I'm not seeing the patch.
Created attachment 285618 [details] [review] proposed fix Grmbl, it seems when I got back to the form (because I had forgotten to select a component), the file upload got dropped (although it was still shown). Anyhow, here it is.
Comment on attachment 285618 [details] [review] proposed fix Okie doke. Master: https://git.gnome.org/browse/orca/commit/?id=42c5db1b 3.14 branch: https://git.gnome.org/browse/orca/commit/?h=gnome-3-14&id=81ff5d412
And 3.12. Debian and its stability... Sheesh. :P https://git.gnome.org/browse/orca/commit/?h=gnome-3-12&id=2f96c19d89
Created attachment 285941 [details] [review] Proposed fix Mmm, maybe I went too far actually. LXDE and XFCE don't seem to implement AutostartCondition, so my proposed patch actually makes orca always start in LXDE and XFCE, whatever the value of screen-reader-enabled in gsettings... So I guess actually we don't want to show that autostart in LXDE and XFCE. Just like KDE, actually: that was the original reason for introducing OnlyShowIn here, apparently. Sorry about this. We can however show it in Cinnamon, which is quite accessible, and does support AutostartCondition. I have attached a patch over the previous one.
Comment on attachment 285941 [details] [review] Proposed fix Thanks for checking and submitting the new patch. * master: https://git.gnome.org/browse/orca/commit/?id=efa3af66249dc * gnome-3-14: https://git.gnome.org/browse/orca/commit/?h=gnome-3-14&id=27fbc5c43d5cac3 * gnome-3-12: https://git.gnome.org/browse/orca/commit/?h=gnome-3-12&id=89de8f820