After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736226 - gnome-user-docs refers to evolution window by wrong title
gnome-user-docs refers to evolution window by wrong title
Status: RESOLVED FIXED
Product: gnome-user-docs
Classification: Core
Component: gnome-help
3.13.x
Other All
: Normal enhancement
: ---
Assigned To: Maintainers of Gnome user documentation
Maintainers of Gnome user documentation
Depends on:
Blocks:
 
 
Reported: 2014-09-07 10:22 UTC by Sebastian Rasmussen
Modified: 2014-09-20 13:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (1.45 KB, patch)
2014-09-07 10:23 UTC, Sebastian Rasmussen 		needs-work Details | Review
Proposed patch. (1.44 KB, patch)
2014-09-07 19:08 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-09-07 10:22:23 UTC 
gnome-user-docs/files-share.page refers to the evolution/geary-window for sending an email with an attachment. The trouble is that the page refers to the window by name. In evolution it is called "Compose Message" in geary "New Message". I believe it is better to rewrite files-share.page to not refer to the window by title.

Also let's fix the missing period.
Comment 1 Sebastian Rasmussen 2014-09-07 10:23:12 UTC 
Created attachment 285610 [details] [review]
Proposed patch.
Comment 2 Michael Hill 2014-09-07 13:33:53 UTC 
Review of attachment 285610 [details] [review]:

Thanks for catching this.

::: gnome-help/C/files-share.page
@@ +50,3 @@
   <item><p>Locate the file you want to transfer.</p></item>
+  <item><p>Right-click the file and select <gui>Email…</gui>. A window
+  appears where you can write the email and have the file attached.</p></item>

It would be better to keep the wording "with the file attached," to indicate that no further action is needed to attach it. Instead of "A window appears where you can write the email," a generic term for "compose email window" ("email compose window"?) would be better.
Comment 3 Sebastian Rasmussen 2014-09-07 19:08:15 UTC 
Created attachment 285617 [details] [review]
Proposed patch.

Updated after review.
Comment 4 Kat 2014-09-07 23:41:03 UTC 
Comment on attachment 285617 [details] [review]
Proposed patch.

Thanks for the patch! Pushed to master in commit 6edad3ce1291dd43ad84495bde556e313572e8a3 after adding a more modern style of indenting.