After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736223 - tab does not navigate from 'Username' to 'Password' in Enterprise Login version of "Add User" window
tab does not navigate from 'Username' to 'Password' in Enterprise Login versi...
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on: 736471
Blocks:
 
 
Reported: 2014-09-07 07:06 UTC by Adam Williamson
Modified: 2014-09-12 12:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
user-accounts: Fix focus in the account dialog (1.16 KB, patch)
2014-09-12 02:01 UTC, Matthias Clasen 		committed Details | Review

Description Adam Williamson 2014-09-07 07:06:13 UTC 
To reproduce, go to control center, Users, click +, click the "Enterprise Login" button, type something in 'Username', and hit tab. You don't wind up in 'Password'. Using 3.13.90-1 (Fedora 21).
Comment 1 Matthias Clasen 2014-09-07 12:47:15 UTC 
Focus seems busted in that dialog everywhere. I can't really see a meaningful focus chain there at all, in both the enterise and the local pages.
Comment 2 Ondrej Holy 2014-09-11 12:24:55 UTC 
Looks like it is caused by:
https://git.gnome.org/browse/gnome-control-center/commit/?id=3695f858dde4d91243885c853302d9b9b2f64bf2

Have you any idea why GtkStack "blocks" the focus?
Comment 3 Matthias Clasen 2014-09-11 17:45:40 UTC 
No idea, will need to investigate. Thanks for the hint
Comment 4 Matthias Clasen 2014-09-12 02:01:04 UTC 
Created attachment 285973 [details] [review]
user-accounts: Fix focus in the account dialog

Making containers take focus is almost never right. In this
case, it disrupts the focus chain in the dialog, because the
focus gets stuck on the stack.
Comment 5 Matthias Clasen 2014-09-12 02:01:37 UTC 
turned out to be simple after all
Comment 6 Bastien Nocera 2014-09-12 07:14:03 UTC 
Review of attachment 285973 [details] [review]:

Thanks!
Comment 7 Matthias Clasen 2014-09-12 12:14:43 UTC 
Attachment 285973 [details] pushed as 177166c - user-accounts: Fix focus in the account dialog