GNOME Bugzilla – Bug 736211
gst-omx: rpi don't inline NAL AU delimiter
Last modified: 2015-07-31 20:38:48 UTC
Created attachment 285596 [details] [review] generate NAL AU delimiter for every frame rpi don't inline AU delimiter so we can't generate valid hls stream for iDevices. this patch add this extension
and this patch will help to https://bugzilla.gnome.org/show_bug.cgi?id=736213
Review of attachment 285596 [details] [review]: Imho, this should always be there, not as a property. And as I mentionned in #736213 and #696037, they should always be there, so no need for the property.
It has default value TRUE If you really want it as default so we should do same for inline SPS/PPS as it is important too
Or maybe we should just outsource this to h264parse? And let the decoder output whatever they like the output (instead of adding the same code everywhere)?
x264enc has this feature that was main point why I made this http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-ugly-plugins/html/gst-plugins-ugly-plugins-x264enc.html#GstX264Enc--aud
Yeah, my point is that we would have to add it to every encoder then :) So why not just keep it in a single place in the parser instead?
so we will dump all AUs on h264parse sink and generate new pretty much as https://bugzilla.gnome.org/show_bug.cgi?id=696037 I have only one problem (hls mux) Every file that came out of h264enc ! h264parse ! tsmux ! multifilesink must start AU SPS PPS IDR so we will need to flag AU somehow
Alright, let's go with that then.
I would rather this was fixed directly in omxh264enc. First, it would make omxh264enc work out the box, and not rely on another module to "fix" the stream somehow. Second, no modifications to h264parse seem to have been made to resolve this issue, so we're talking about a fix that doesn't exist. There is a further behaviour I have found where the addition of h264parse to the pipeline breaks hlssink - only one ts fragment is created which grows without bound. There are a significant amount of duplicates of bugs that say "HLS to Safari/iOS doesn't work", this patch will fix all of them.