Created attachment 285590 [details] [review]
Rework the well done dialog

The buttons should be actions, and sudoku is a long enough game that
there's not much value in letting players skip the one-click new game
screen.

Created attachment 285591 [details] [review]
Rework the well done dialog

The buttons should be actions, and sudoku is a long enough game that
there's not much value in letting players skip the one-click new game
screen. And the dialog should be modal.

Without having tested the patches, the problem I see with making the dialog modal is that you cannot have a look to the finished game, you cannot restart it (try to do it in less time), and you cannot think for example to print it for your friends…

And, a "Well done, you completed the puzzle in 846 minutes!" dialog would look quite ironical I think; we should prefer something like "Well done, you completed the puzzle! It took %d minutes."

Oh, related actual bug: you can undo-redo when the game is finished, and then you have a second/another “Well done!” dialog that popups, with a different timer… Maybe we should at least stop the timer?

Alas, I think we're not supposed to use non-modal dialogs in GNOME.

(In reply to comment #4)
> Oh, related actual bug: you can undo-redo when the game is finished, and then
> you have a second/another “Well done!” dialog that popups, with a different
> timer… Maybe we should at least stop the timer?

I think it does not make sense to allow undo after the game is over. That's only reasonable in games where the player can lose. Can you file a different bug for that please?

(In reply to comment #3)
> Without having tested the patches, the problem I see with making the dialog
> modal is that you cannot have a look to the finished game

Good point.  Well, you can do this by pressing Escape, but who would know to do that.

> you cannot restart
> it (try to do it in less time),

Nobody would want to do that. :p

> and you cannot think for example to print it
> for your friends…

Another good point.

> And, a "Well done, you completed the puzzle in 846 minutes!" dialog would look
> quite ironical I think; we should prefer something like "Well done, you
> completed the puzzle! It took %d minutes."

Yeah, but we has a clock patch accepted already for 3.16 so we can actually completely delete the mention of time.

I think the mid-term solution to your objections is to figure out how to remove this dialog, while still making it clear that the player won the game.  I'll push this in the meantime (to master, NOT gnome-3-14, so we've got plenty of time to change our minds).

Attachment 285591 [details] pushed as 29ce0f5 - Rework the well done dialog