GNOME Bugzilla – Bug 736165
gnome style UI
Last modified: 2014-11-11 23:31:22 UTC
Created attachment 285535 [details] geary after ui modification I propose to change a little bit the geary UI to be clearer and be like others gnome application. I try to have the same look than file (nautilus).
Created attachment 285536 [details] geary before ui modification I add another screenshot to be able to compare
It looks to me you're proposing (a) to put a slight border on the inside of the folder list and the conversation list, (b) removing the status bar at the bottom of the folder list, and (c) adding a grip between the conversation list and the conversation viewer. Is there anything else I'm missing?
Created attachment 285540 [details] [review] patch for this bug In fact, I just think about changing some CSS stuff. Here is a patch. (Maybe this is not the best way to do that, I'm a beginner in vala/GTK application)
There are some problems with my patch when we use gnome dark theme. I will search a more elegant way to do that.(by limiting the use of color constants) Maybe I should remove some GtkFrame instead of hiding their border.
Created attachment 285646 [details] [review] a better patch for this bug I remove some frames and use @define color of Adwaita theme. The code is clearer and it works well with dark theme. I see the use of "sidebar-pane-separator" class (line 195 in main.windows.vala), I can't find it's purpose.
Do not hesitate to tell me if I'm totally in a wrong way.
Created attachment 286257 [details] Screenshot I've added the "review" comment to the whiteboard, which we use to note bugs with patches. When I run with this patch, the only difference I notice is that the resize handle between the conversation list and the conversation view is different: the background is no longer a different color, but there is a series of dots in the middle. I've attached a screenshot demonstrating what I see.
I never test it on ubuntu, so with ubuntu theme. (I'm on Debian testing) I just remove the frame of folder_pane and viewer_pane to remove border. I remove top and bottom border of conversation frame too. I let the right and left border to have the same look than nautilus. (https://developer.gnome.org/gtk3/stable/GtkFrame.html) And I try to make the UI lighter by using same color for handle and folder list, handle and conversation viewer. https://developer.gnome.org/gtk3/stable/GtkPaned.html Like nautilus http://lh3.ggpht.com/-2T9cGXLFnC8/UzKTUp0GevI/AAAAAAABU78/UqVMDpgbndk/s1200/nautilus-312.jpg So I use constants of Adwaita theme for folder_pane. (@sidebar_bg) And the color defined in the geary CSS for conversation viewer. On ubuntu, it seems frame as no border, so my first modification is not visible. I don't understand why status bar and folder_list have not the same color, I suppose ubuntu theme does not define the class SIDEBAR. https://developer.gnome.org/gtk3/stable/GtkStyleContext.html#GTK-STYLE-CLASS-SIDEBAR:CAPS I also don't understand why the handler is different, just the color must be changed. :( (I don't see in nautilus sourcecode reference of @sidebar_bg, I can not find how they do exactly to have the handle of gtkpaned with the color of sidebar background. https://git.gnome.org/browse/nautilus/tree/src/nautilus-window.c#n849)
Jim, can you take a look at this? I've been thinking about bug #714793, and it's going to hit the same bits of code.
Review of attachment 285646 [details] [review]: Simon, thanks for your patience, I've been dog-paddling this month. This does clean up the window a bit, so I appreciate where you're going with this. I'm running Adwaita and I see this: * The status bar at the bottom of the folder list no longer has any color differentiation (background color) and has no border. The problem is when the user expands their folder list (assuming they have a lot of folders). The list will look "cut off" at the bottom. With the color differentiation, it's a clue to the eye as to what's going on there. Now, there's some discussion at bug #714793 that will introduce some changes to the status bar, so perhaps that should be taken into consideration here. * As Robert mentioned, the grips for the Paned between the conversation list and conversation viewer are hidden until the user mouses over them, and then only the grips appear. They're doing that in Nautilus, and I'm okay with it. It does remove some chrome from the screen, which is nice. I, for one, wouldn't mind if Geary's sidebar looked more like the sidebar in Nautilus, but we do have a few different things going on here (the status bar, the GtkTreeView) and so we need to respect that. Maybe Robert has some ideas about how the status bar question, or perhaps we should hold off on that until Robert's done with his patch. But I would be interested in getting the Geary sidebar the same color as the conversation list; knowing the mountain of issues with GtkTreeView (we've had CSS theming problems with it in the past), it might be more tricky than it would seem.
*** Bug 737074 has been marked as a duplicate of this bug. ***
Bug #737074 reports some double-borders in Geary. I believe Simon's patch solves this issue.
(In reply to comment #10) > * As Robert mentioned, the grips for the Paned between the conversation list > and conversation viewer are hidden until the user mouses over them, and then > only the grips appear. They're doing that in Nautilus, and I'm okay with it. > It does remove some chrome from the screen, which is nice. That's not actually what I'm seeing. With this patch, the two separators have a different appearance. The left one is light gray with no grips (as it was before) and the right one is darker gray (or perhaps transparent -- it's the same color as the background of the conversation view) with grips. Grips or no grips, I don't really care; but they should be the same.
Created attachment 287141 [details] geary ui modification (gnome 3.14) I really don't know why left panel has no grips and the right panel has one with the ubuntu theme oO. I'm just testing gnome 3.14 and they made lot of changes on Adwaita theme. The grips between GtkPaned is no more. There just a one pixel line. http://3.bp.blogspot.com/-of_zsCN9ef8/VCO7gUiTszI/AAAAAAABh24/tJRFn15SfBk/s1600/gnome_3-14-nautilus.jpg So If you aim gnome 3.14 the patch should just be removing the 3 frame (folder,conversion list, conversation viewer) (see attachment) In this case, the background color change of GtkPaned is not more needed, maybe this will avoid the strange behavior with ubuntu theme. But there're still have the problem about status bar. (for me it's not a blocking one, but I agree this should be better if the status bar was displayed only when necessary like the nautilus one) http://askubuntu.com/questions/286430/nautilus-3-6-doesnt-have-a-status-bar/289361#289361
Created attachment 289412 [details] Borderless GtkFrames I played a bit with GtkInspector and I got to the point of the screenshot attached. Steps: 1) completely remove the borders from ConverSationListView's parent GtkFrame. 2) remove all but bottom border from FolderListTree's parent GtkFrame. Magic is done and it get's really really awsome.
That looks pretty clean! Do you have a patch?
Created attachment 289552 [details] [review] Borderless GtkFrame patch Sure, here it goes. It respects the theme's border's width.
Review of attachment 289552 [details] [review]: This still doesn't look right to me. I don't get fine lines, I get blankness in the UI. I tried it under 14.04, 14.10, and F21 w/ Adwaita. What distro and theme are you using? Have you customized the theme in some way?
Created attachment 289558 [details] Screenshot w/ patch applied
I'm using Arch Linux with GNOME 3.14, and my theme is not modified. With Gtk+ 3.14, Gtk.Paned has a 1px line (at leat with Adwaita). I think it won't work with Ubuntu's theme and/or Gtk+ 3.12.
Whoops, I take some of that back. I didn't apply the patch properly under F21. Now that I have, it looks more like your screenshot. It may be that these changes only work well under GTK+ 3.14 (as your last response guesses). The problem with that is, the next version of Geary (0.10) needs to work under Utopic, which is at 3.12 (and even then, with some theme issues of its own; don't get me started). Is it possible for you to try tweaking these changes so they work under 3.12 and up? If not, we'll have to think of something else.
Created attachment 289559 [details] [review] Borderless GtkFrame patch Sure, here it goes. I reinforce that this patch is made specially for Gtk+ 3.12. IMHO, an option would be generating 2 CSS files, for 3.12 & 3.14, and Geary loads them at runtime. But I don't know if all this mess is worth the effort.
Created attachment 289574 [details] [review] Borderless GtkFrame (dynamic selection) So, here it goes again. This patch is ugly, very ugly, and I really don't know if it fits Yorba's high coding standards. Anyway, it surely may be used as base for future work, as it works for both Gtk+ 3.14 & 3.12.
This patch seems to work fine for me (3.10, Ambiance theme), for whatever that's worth. A few thoughts on the patch itself: - If we're testing the minor version number, we should also test the major version. We don't want the old code reactivated when GTK goes to 4.0. (Obviously we'd plan to take the test out before then, but things don't always go to plan.) - Can the CSS statements for the different versions be combined? For instance, .conversation_frame { border-top-width: 0px; border-bottom-width: 0px; border-width: 0px; } With HTML, unknown CSS statements will be ignored. If GTK behaves the same way, it may be possible to avoid the explicit version check.
Created attachment 289620 [details] [review] Borderless GtkFrame Right, this was the minimum code I've been able to reach. I hope it's enought.
Created attachment 289621 [details] [review] Borderless GtkFrames Forget my last patch, it doesn't work as expected. Resolved with this one (I hope so).
Thanks for your diligence! Pushed to master, commit 01355a