GNOME Bugzilla – Bug 736151
gnome-user-docs refers to old version of UI: "Linked contacts"
Last modified: 2014-10-08 20:47:54 UTC
The documentation here refers to "Linked contacts": https://git.gnome.org/browse/gnome-user-docs/tree/gnome-help/C/contacts-link-unlink.page#n71 This despite this part of the UI changing back in 2011: https://git.gnome.org/browse/gnome-contacts/commit/?id=9ed5741b168f79955c7261fd0dd0c542613bcc65 I discovered this while trying to verify that my translation to Swedish of gnome-user-docs was correct
Created attachment 287530 [details] [review] changed the name of a UI button in user-docs, Linked Contacts to Linked Accounts.
Hi Varshini, Thank you very much for your patch. The first part of it is correct in that the UI has changed from "Linked Contacts" to "Linked Accounts," but the second part of the instructions remain the same. As of GNOME 3.14, the UI still says, "Unlink", but your patch has changed this to "Remove". Please resubmit your patch after you've reinstated the word "Unlink". Also, please review the GNOME git commit guidelines as shown here: https://wiki.gnome.org/Git/CommitMessages Thank you for your work! I appreciate you taking the time to submit these patches!
Created attachment 288027 [details] [review] Documentation changes, Updated the label of UI button, 'Linked contacts' to 'Linked Accounts'
(In reply to comment #3) > Created an attachment (id=288027) [details] [review] > Documentation changes, Updated the label of UI button 'Linked contacts' to 'Linked Accounts'.
Comment on attachment 288027 [details] [review] Documentation changes, Updated the label of UI button, 'Linked contacts' to 'Linked Accounts' >From ab8f5bb60c3521ddd508c2007951f6a79534269d Mon Sep 17 00:00:00 2001 >From: varshiniramesh <varshinir4@gmail.com> >Date: Wed, 8 Oct 2014 08:58:42 +0530 >Subject: [PATCH] gnome-user-docs: Documentation changes, the UI button label > name was changed from 'Linked contacts' to 'Linked Accounts'. > >https://bugzilla.gnome.org/show_bug.cgi?id=736151 >--- > gnome-help/C/contacts-link-unlink.page | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/gnome-help/C/contacts-link-unlink.page b/gnome-help/C/contacts-link-unlink.page >index 288d210..caf0ec1 100644 >--- a/gnome-help/C/contacts-link-unlink.page >+++ b/gnome-help/C/contacts-link-unlink.page >@@ -68,7 +68,7 @@ > <app>Contacts</app>.</p> > </item> > <item> >- <p>Press <gui style="button">Linked Contacts</gui>.</p> >+ <p>Press <gui style="button">Linked Accounts</gui>.</p> > </item> > <item> > <p>Press <gui style="button">Unlink</gui> to unlink the entry from the >-- >1.8.3.1 >
Comment on attachment 288027 [details] [review] Documentation changes, Updated the label of UI button, 'Linked contacts' to 'Linked Accounts' Pushed to master in commit dc65449643aa648e9f8ea3dd72da172d742c4813 after changing the commit message so that the first line is under 50 characters long. (gnome-user-docs is the repository, if you want to use something to prefix the commit message, then 'gnome-help' would work best.)