After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736140 - properties returns to machine if it is not active
properties returns to machine if it is not active
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: properties
3.13.x
Other Linux
: Normal normal
: 3.22
Assigned To: Lasse Schuirmann
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-05 16:10 UTC by Lasse Schuirmann
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
machine: Go to COLLECTION from explicit states only (1.21 KB, patch)
2014-09-05 16:45 UTC, Lasse Schuirmann 		committed Details | Review
machine: Update screenshot on machine disconnect (991 bytes, patch)
2014-09-05 16:45 UTC, Lasse Schuirmann 		committed Details | Review
properties-toolbar: Return to COLLECTION if VM is not running (972 bytes, patch)
2014-09-05 16:45 UTC, Lasse Schuirmann 		committed Details | Review

Description Lasse Schuirmann 2014-09-05 16:10:08 UTC 
Steps to reproduce:
1. Start a machine
2. Go to properties
3. Press "Force Shutdown"
4. Acknoledge the force shutdown
5. Go back

Actual results:
A frozen last state of the VM.

Expected results:
On pressing back we return to collection view.

Analysis:
I bisected the issue down to commit 7c91133a. Since then we dont return from properties when the machine disconnects automatically.

As an implication on the disconnect event we should show a black screenshot to indicate that the VM is off to the user and return to collection view if the user presses the back button and the VM is still disconnected.
Comment 1 Lasse Schuirmann 2014-09-05 16:45:06 UTC 
Created attachment 285506 [details] [review]
machine: Go to COLLECTION from explicit states only

When the machine disconnects and UIState is CREDS or DISPLAY we want to
return to COLLECTION view. However in some other states, like WIZARD
this doesnt make sense. This is why we shouldnt just exclude PROPERTIES
state from the affected comparision.
Comment 2 Lasse Schuirmann 2014-09-05 16:45:09 UTC 
Created attachment 285507 [details] [review]
machine: Update screenshot on machine disconnect

If a machine disconnects we want to update the screenshot so if the user
is at the properties view he will get an indication that it is no longer
running.
Comment 3 Lasse Schuirmann 2014-09-05 16:45:13 UTC 
Created attachment 285508 [details] [review]
properties-toolbar: Return to COLLECTION if VM is not running
Comment 4 Zeeshan Ali 2014-09-05 18:34:17 UTC 
Actually with latest git master, I can't reproduce this. What happens is after step#4, Boxes automatically goes back to collection view.
Comment 5 Lasse Schuirmann 2014-09-05 19:00:33 UTC 
But what problem did you have then? Thats weird. I pulled again from master and still have the behaviour described in the initial report of this bug. Wasnt it for commit 7c91133a that boxes does not automatically switch to collection view when a VM disconnects? (Thus boxes doesnt interrupt the user.)
Comment 6 Zeeshan Ali 2014-09-09 18:25:20 UTC 
Hmm.. I can reproduce this now. weird :)
Comment 7 Zeeshan Ali 2014-09-09 23:04:25 UTC 
Review of attachment 285506 [details] [review]:

I guess it makes sense.
Comment 8 Zeeshan Ali 2014-09-09 23:05:54 UTC 
Review of attachment 285507 [details] [review]:

this too seems to make sense
Comment 9 Zeeshan Ali 2014-09-09 23:06:47 UTC 
Review of attachment 285508 [details] [review]:

Make sense
Comment 10 Lasse Schuirmann 2014-09-10 06:50:02 UTC 
Attachment 285506 [details] pushed as 17062b8 - machine: Go to COLLECTION from explicit states only
Attachment 285507 [details] pushed as dad7213 - machine: Update screenshot on machine disconnect
Attachment 285508 [details] pushed as b68642b - properties-toolbar: Return to COLLECTION if VM is not running