GNOME Bugzilla – Bug 736134
curlsmtpsink: Adding final boundary for every sending out email
Last modified: 2014-10-06 12:44:01 UTC
Created attachment 285503 [details] [review] Add final boundary at the end of each email gstcurlsmtpsink only add final boundary for the sending out email when the transfer thread is about to be ended. However, before that, the thread could send out multiple emails. And each of the email shall end with a final boundary if the content-Type is multipart/mixed.
Comment on attachment 285503 [details] [review] Add final boundary at the end of each email This patch does not apply against latest GIT master, but otherwise seems to make sense. Why only in the is_live case though? Can you attach a new patch against git master in "git format-patch" format?
Created attachment 286638 [details] [review] New patch You are right, it is unnecessary to check 'is_live'.
Comment on attachment 286638 [details] [review] New patch Can you attach this in "git format-patch" format with a proper commit message?
Created attachment 286970 [details] [review] "git format-patch" formated patch.
commit 22e09f19edd45596b3bf9d7c22d156644f278f33 Author: Lihua Liu <lihual@axis.com> Date: Wed Sep 24 12:42:23 2014 +0200 curlsmtpsink: Email with multipart content-type should end with a final boundary Add final boundary for each of the sending out emails from smtpsink. https://bugzilla.gnome.org/show_bug.cgi?id=736134
Created attachment 287064 [details] [review] New complete commit "bcsink->is_live" need to be checked, it allows you to include multiple images in one email.
Comment on attachment 287064 [details] [review] New complete commit Please provide a patch against git master that also applies :)
Created attachment 287502 [details] [review] Patch New patch
Comment on attachment 287502 [details] [review] Patch It still does not apply against git master
commit 47abcb9a6b0be6b11f3e9cfdaadd9444ffc9ace8 Author: Lihua Liu <lihual@axis.com> Date: Wed Oct 1 10:57:26 2014 +0200 curlsmtpsink: Email with multipart content-type should end with a final boundary Add final boundary for each of the sending out emails from smtpsink. https://bugzilla.gnome.org/show_bug.cgi?id=736134
Merged it manually now