After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736134 - curlsmtpsink: Adding final boundary for every sending out email
curlsmtpsink: Adding final boundary for every sending out email
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.22
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-05 14:57 UTC by Lihua Liu
Modified: 2014-10-06 12:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add final boundary at the end of each email (729 bytes, patch)
2014-09-05 14:57 UTC, Lihua Liu
needs-work Details | Review
New patch (649 bytes, patch)
2014-09-19 15:24 UTC, Lihua Liu
needs-work Details | Review
"git format-patch" formated patch. (1.01 KB, patch)
2014-09-24 11:04 UTC, Lihua Liu
committed Details | Review
New complete commit (1009 bytes, patch)
2014-09-25 11:52 UTC, Lihua Liu
needs-work Details | Review
Patch (1.04 KB, patch)
2014-10-01 09:33 UTC, Lihua Liu
committed Details | Review

Description Lihua Liu 2014-09-05 14:57:13 UTC
Created attachment 285503 [details] [review]
Add final boundary at the end of each email

gstcurlsmtpsink only add final boundary for the sending out email when the transfer thread is about to be ended. However, before that, the thread could send out multiple emails. And each of the email shall end with a final boundary if the content-Type is multipart/mixed.
Comment 1 Sebastian Dröge (slomo) 2014-09-12 13:05:05 UTC
Comment on attachment 285503 [details] [review]
Add final boundary at the end of each email

This patch does not apply against latest GIT master, but otherwise seems to make sense.

Why only in the is_live case though?

Can you attach a new patch against git master in "git format-patch" format?
Comment 2 Lihua Liu 2014-09-19 15:24:03 UTC
Created attachment 286638 [details] [review]
New patch

You are right, it is unnecessary to check 'is_live'.
Comment 3 Sebastian Dröge (slomo) 2014-09-24 07:33:51 UTC
Comment on attachment 286638 [details] [review]
New patch

Can you attach this in "git format-patch" format with a proper commit message?
Comment 4 Lihua Liu 2014-09-24 11:04:33 UTC
Created attachment 286970 [details] [review]
"git format-patch" formated patch.
Comment 5 Sebastian Dröge (slomo) 2014-09-25 08:17:27 UTC
commit 22e09f19edd45596b3bf9d7c22d156644f278f33
Author: Lihua Liu <lihual@axis.com>
Date:   Wed Sep 24 12:42:23 2014 +0200

    curlsmtpsink: Email with multipart content-type should end with a final boundary
    
    Add final boundary for each of the sending out emails from smtpsink.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=736134
Comment 6 Lihua Liu 2014-09-25 11:52:19 UTC
Created attachment 287064 [details] [review]
New complete commit

"bcsink->is_live" need to be checked, it allows you to include multiple images in one email.
Comment 7 Sebastian Dröge (slomo) 2014-09-26 07:41:14 UTC
Comment on attachment 287064 [details] [review]
New complete commit

Please provide a patch against git master that also applies :)
Comment 8 Lihua Liu 2014-10-01 09:33:12 UTC
Created attachment 287502 [details] [review]
Patch

New patch
Comment 9 Sebastian Dröge (slomo) 2014-10-02 07:17:42 UTC
Comment on attachment 287502 [details] [review]
Patch

It still does not apply against git master
Comment 10 Sebastian Dröge (slomo) 2014-10-06 12:43:43 UTC
commit 47abcb9a6b0be6b11f3e9cfdaadd9444ffc9ace8
Author: Lihua Liu <lihual@axis.com>
Date:   Wed Oct 1 10:57:26 2014 +0200

    curlsmtpsink: Email with multipart content-type should end with a final boundary
    
        Add final boundary for each of the sending out emails from smtpsink.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=736134
Comment 11 Sebastian Dröge (slomo) 2014-10-06 12:44:01 UTC
Merged it manually now