After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736133 - v4l2: query crop configuration after each call of S_CROP
v4l2: query crop configuration after each call of S_CROP
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-05 14:46 UTC by Aurélien Zanelli
Modified: 2015-02-26 14:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
v4l2: query crop configuration after each call of S_CROP (1.56 KB, patch)
2014-09-05 14:48 UTC, Aurélien Zanelli
committed Details | Review

Description Aurélien Zanelli 2014-09-05 14:46:39 UTC
S_CROP ioctl is write-only and the device can adjust crop rectangle so we have to query crop configuration after each call of S_CROP to know if it has been adjusted or not. I will attach a simple patch for that.

A more serious thing is that, according to specification, a driver could also change the configured format on a S_CROP so we may have to do something in this case if some drivers do this.
Comment 1 Aurélien Zanelli 2014-09-05 14:48:56 UTC
Created attachment 285502 [details] [review]
v4l2: query crop configuration after each call of S_CROP

Simple patch to at least query crop configuration after a call to S_CROP.
Comment 2 Nicolas Dufresne (ndufresne) 2014-09-05 15:12:56 UTC
hmm, also the SELECTION API is suppose to be the new shiny thing, didn't read that part of the spec yet, what's your input on that ?
Comment 3 Aurélien Zanelli 2014-09-05 15:23:10 UTC
I didn't take a deep look into the selection API but it seems more coherent and easier to use/implement.
We began to implement it in our drivers so I think I will use it sooner and I may implement it in Gstreamer except if someone do this earlier.
Comment 4 Nicolas Dufresne (ndufresne) 2015-02-26 13:36:02 UTC
Review of attachment 285502 [details] [review]:

This make sense.
Comment 5 Nicolas Dufresne (ndufresne) 2015-02-26 14:22:13 UTC
Review of attachment 285502 [details] [review]:

commit 88703ae585191fb76fe0b9b6351f79e0c82936a6
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Fri Sep 5 16:34:26 2014 +0200

    v4l2: query crop configuration after each call of S_CROP
    
    S_CROP ioctl is write-only and the device can adjust crop rectangle so
    we query back the crop configuration after each S_CROP to know what has
    been done.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=736133