GNOME Bugzilla – Bug 736133
v4l2: query crop configuration after each call of S_CROP
Last modified: 2015-02-26 14:22:28 UTC
S_CROP ioctl is write-only and the device can adjust crop rectangle so we have to query crop configuration after each call of S_CROP to know if it has been adjusted or not. I will attach a simple patch for that. A more serious thing is that, according to specification, a driver could also change the configured format on a S_CROP so we may have to do something in this case if some drivers do this.
Created attachment 285502 [details] [review] v4l2: query crop configuration after each call of S_CROP Simple patch to at least query crop configuration after a call to S_CROP.
hmm, also the SELECTION API is suppose to be the new shiny thing, didn't read that part of the spec yet, what's your input on that ?
I didn't take a deep look into the selection API but it seems more coherent and easier to use/implement. We began to implement it in our drivers so I think I will use it sooner and I may implement it in Gstreamer except if someone do this earlier.
Review of attachment 285502 [details] [review]: This make sense.
Review of attachment 285502 [details] [review]: commit 88703ae585191fb76fe0b9b6351f79e0c82936a6 Author: Aurélien Zanelli <aurelien.zanelli@parrot.com> Date: Fri Sep 5 16:34:26 2014 +0200 v4l2: query crop configuration after each call of S_CROP S_CROP ioctl is write-only and the device can adjust crop rectangle so we query back the crop configuration after each S_CROP to know what has been done. https://bugzilla.gnome.org/show_bug.cgi?id=736133