GNOME Bugzilla – Bug 736122
ximagesrc: setting the screen-num property has no effect
Last modified: 2014-09-16 07:36:58 UTC
Hi, the screen-num property exposed by ximagesrc does not seem to have any effect, the value is set but never used by any code AFAICS. The property should be fixed or removed. I can try to fix it, but considering that the screen can also be specified as part of the display-name property (e.g. display-name=":0.1") we should think to some scheme for when the screen is specified using both mechanisms at the same time (e.g. display-name="0.0" screen-num=1) I'd vote for dropping screen-num altogether. Thanks, Antonio
Dropping it seems like the best solution, yes. Nobody is going to complain as it had no effect anyway ;)
Created attachment 286196 [details] [review] ximagesrc: Remove unused screen-num property Here is a patch to remove the screen-num property. While at it I removed also the internal variables for the screen number, they are not really needed. The patch is against the 1.4 branch. Thanks, Antonio
commit 80fa912b06582722ac20829b7741de66964e721f Author: Antonio Ospite <ao2@ao2.it> Date: Mon Sep 15 14:39:41 2014 +0200 ximagesrc: Remove unused screen-num property The screen number can be still specified as part of the display-name property (e.g. for screen 1 of display 0 use display-name=":0.1"). https://bugzilla.gnome.org/show_bug.cgi?id=736122