After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736107 - Add places from route planner to place store
Add places from route planner to place store
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-05 09:54 UTC by Jonas Danielsson
Modified: 2014-09-05 18:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
placeEntry: Clean up place setter (1.79 KB, patch)
2014-09-05 09:56 UTC, Jonas Danielsson
committed Details | Review
Add recent places from PlaceEntry (1.44 KB, patch)
2014-09-05 09:56 UTC, Jonas Danielsson
committed Details | Review

Description Jonas Danielsson 2014-09-05 09:54:50 UTC
Right now places we find during route search are not added to the place store. This means they will not show up as completion suggestions.

Lets fix that.
Comment 1 Jonas Danielsson 2014-09-05 09:56:21 UTC
Created attachment 285462 [details] [review]
placeEntry: Clean up place setter
Comment 2 Jonas Danielsson 2014-09-05 09:56:43 UTC
Created attachment 285463 [details] [review]
Add recent places from PlaceEntry
Comment 3 Damián Nohales 2014-09-05 16:21:56 UTC
Review of attachment 285462 [details] [review]:

Looks fine.

::: src/placeEntry.js
@@ +35,3 @@
+    return (location.latitude === this.latitude &&
+            location.longitude === this.longitude);
+};

Bastien will kill you for this :)
Comment 4 Damián Nohales 2014-09-05 16:29:11 UTC
Review of attachment 285463 [details] [review]:

Looks fine.

::: src/placeEntry.js
@@ +58,2 @@
             this.text = p.name;
+            Application.placeStore.addRecent(p);

Note to self: I must be careful when I re-work the plain coordinate stuff (#735842) to not store unnamed places and we need to discuss if is appropriate to store places named throught Android like geo URIs: "geo:0,0?q=latitude,longitude(description)".
Comment 5 Jonas Danielsson 2014-09-05 18:17:05 UTC
Review of attachment 285462 [details] [review]:

I will send a patch to add the equals to GeocodeLocation when 3.15 starts :)
Comment 6 Jonas Danielsson 2014-09-05 18:26:33 UTC
Attachment 285462 [details] pushed as 23166c6 - placeEntry: Clean up place setter
Attachment 285463 [details] pushed as 7abbfde - Add recent places from PlaceEntry