GNOME Bugzilla – Bug 736107
Add places from route planner to place store
Last modified: 2014-09-05 18:26:40 UTC
Right now places we find during route search are not added to the place store. This means they will not show up as completion suggestions. Lets fix that.
Created attachment 285462 [details] [review] placeEntry: Clean up place setter
Created attachment 285463 [details] [review] Add recent places from PlaceEntry
Review of attachment 285462 [details] [review]: Looks fine. ::: src/placeEntry.js @@ +35,3 @@ + return (location.latitude === this.latitude && + location.longitude === this.longitude); +}; Bastien will kill you for this :)
Review of attachment 285463 [details] [review]: Looks fine. ::: src/placeEntry.js @@ +58,2 @@ this.text = p.name; + Application.placeStore.addRecent(p); Note to self: I must be careful when I re-work the plain coordinate stuff (#735842) to not store unnamed places and we need to discuss if is appropriate to store places named throught Android like geo URIs: "geo:0,0?q=latitude,longitude(description)".
Review of attachment 285462 [details] [review]: I will send a patch to add the equals to GeocodeLocation when 3.15 starts :)
Attachment 285462 [details] pushed as 23166c6 - placeEntry: Clean up place setter Attachment 285463 [details] pushed as 7abbfde - Add recent places from PlaceEntry