After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736079 - Fix the icons in RTL with newer GTK+
Fix the icons in RTL with newer GTK+
Status: RESOLVED FIXED
Product: sushi
Classification: Core
Component: viewers
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Sushi maintainer(s)
Sushi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-04 21:02 UTC by Yosef Or Boczko
Modified: 2014-09-04 21:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: require GTK+ 3.13.2 (702 bytes, patch)
2014-09-04 21:07 UTC, Yosef Or Boczko 		committed Details | Review
evince-viewer: Fix the icons in RTL (1.69 KB, patch)
2014-09-04 21:07 UTC, Yosef Or Boczko 		committed Details | Review
audio: Fix the icons in RTL (1.02 KB, patch)
2014-09-04 21:08 UTC, Yosef Or Boczko 		committed Details | Review
gst: Fix the icons in RTL (1022 bytes, patch)
2014-09-04 21:08 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2014-09-04 21:02:13 UTC 
Newer GTK+ handle RTL icons. he looking for the name icon with suffix -rtl,
after the -symbolic (not before).
Because the -rtl-symbolic icons are removed, we needs to remove the custom
RTL icons handling, and bump the GTK+ version.

See the patches.
Comment 1 Yosef Or Boczko 2014-09-04 21:07:38 UTC 
Created attachment 285416 [details] [review]
build: require GTK+ 3.13.2
Comment 2 Yosef Or Boczko 2014-09-04 21:07:53 UTC 
Created attachment 285417 [details] [review]
evince-viewer: Fix the icons in RTL
Comment 3 Yosef Or Boczko 2014-09-04 21:08:05 UTC 
Created attachment 285418 [details] [review]
audio: Fix the icons in RTL
Comment 4 Yosef Or Boczko 2014-09-04 21:08:19 UTC 
Created attachment 285419 [details] [review]
gst: Fix the icons in RTL
Comment 5 Yosef Or Boczko 2014-09-04 21:08:43 UTC 
Infact, this patches revert my patches from bug #705017.
Comment 6 Cosimo Cecchi 2014-09-04 21:09:49 UTC 
Review of attachment 285416 [details] [review]:

OK
Comment 7 Cosimo Cecchi 2014-09-04 21:10:07 UTC 
Review of attachment 285417 [details] [review]:

LG
Comment 8 Cosimo Cecchi 2014-09-04 21:10:21 UTC 
Review of attachment 285418 [details] [review]:

LG
Comment 9 Cosimo Cecchi 2014-09-04 21:10:33 UTC 
Review of attachment 285419 [details] [review]:

LG
Comment 10 Yosef Or Boczko 2014-09-04 21:12:30 UTC 
Review of attachment 285416 [details] [review]:

Pushed as f4b6c1c - build: require GTK+ 3.13.2
Comment 11 Yosef Or Boczko 2014-09-04 21:12:56 UTC 
Review of attachment 285417 [details] [review]:

Pushed as f63ee72 - evince-viewer: Fix the icons in RTL
Comment 12 Yosef Or Boczko 2014-09-04 21:13:16 UTC 
Review of attachment 285418 [details] [review]:

Pushed as 6a77fa8 - audio: Fix the icons in RTL
Comment 13 Yosef Or Boczko 2014-09-04 21:13:34 UTC 
Review of attachment 285419 [details] [review]:

Pushed as 49d625b - gst: Fix the icons in RTL
Comment 14 Yosef Or Boczko 2014-09-04 21:14:01 UTC 
Thanks for the quick review - really quick :-)