After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736059 - Avoid use-stock property in GtkBuilder files
Avoid use-stock property in GtkBuilder files
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-04 14:48 UTC by David King
Modified: 2014-12-27 17:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to avoid warning (9.61 KB, patch)
2014-09-04 14:49 UTC, David King 		none Details | Review
new strings should also be marked translatable (9.81 KB, patch)
2014-09-04 14:54 UTC, David King 		committed Details | Review

Description David King 2014-09-04 14:48:36 UTC 
With a recent GLib, warnings are printed to the terminal when gnome-calculator is run, because of stock cancel labels:

(gnome-calculator:2831): GLib-GObject-WARNING **: The property GtkButton:use-stock is deprecated and shouldn't be used anymore. It will be removed in a future version.
Comment 1 David King 2014-09-04 14:49:50 UTC 
Created attachment 285385 [details] [review]
patch to avoid warning

This patch adds translatable strings, so is too late for 3.14 without a freeze break.
Comment 2 David King 2014-09-04 14:54:16 UTC 
Created attachment 285386 [details] [review]
new strings should also be marked translatable
Comment 3 PioneerAxon 2014-12-27 17:32:49 UTC 
Review of attachment 285386 [details] [review]:

Committed..

Thanks.. :)