GNOME Bugzilla – Bug 736052
Avoid some deprecated properties in GtkBuilder files
Last modified: 2015-01-25 13:09:05 UTC
There are some deprecated properties used in GtkBuilder files, which show up in the journal now: (gnome-control-center:17428): GLib-GObject-WARNING **: The property GtkButton:use-stock is deprecated and shouldn't be used… I also found that has-resize-grip was also still present.
Created attachment 285366 [details] [review] avoid use-stock
Created attachment 285367 [details] [review] avoid has-resize-grip
Review of attachment 285366 [details] [review]: There's one new string: _Help Can you split this up into something we can merge now, and the other small fix for 3.16?
Review of attachment 285367 [details] [review]: Looks good. Add the "panels: " prefix to the commit subject
Review of attachment 285367 [details] [review]: Pushed with that change, thanks!
Created attachment 285369 [details] [review] avoid use-stock (without new _Help string)
Created attachment 285370 [details] [review] avoid last use-stock use, and add _Help string
Review of attachment 285369 [details] [review]: Looks good.
Review of attachment 285370 [details] [review]: For 3.16, or before if you have the time to request that from gnome-i18n. I wouldn't bother, it's just a warning that should be disabled in stable versions.
Review of attachment 285369 [details] [review]: Thanks. Pushed to master.
Created attachment 285390 [details] [review] add _Help string and mark it as translatable Forgot to mark the new string as translatable.
Created attachment 285391 [details] [review] mark already-merged label strings as translatable
Review of attachment 285391 [details] [review]: Yes!
Review of attachment 285391 [details] [review]: Pushed! Sorry for the trouble.
Review of attachment 285390 [details] [review]: Ready for when we've branched
(In reply to comment #15) > Review of attachment 285390 [details] [review]: > Ready for when we've branched ping - Patch here is set to "accepted-commit_after_freeze" and might be nice to get it in before it is again blocke by a freeze.