After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735988 - Remove libxkbcommon autogenargs to prevent gnome-shell from crashing on FreeBSD
Remove libxkbcommon autogenargs to prevent gnome-shell from crashing on FreeBSD
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2014-09-03 18:39 UTC by Ting-Wei Lan
Modified: 2015-06-14 06:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add FreeBSD-specific autogenargs for libxkbcommon (1.19 KB, patch)
2014-09-03 18:39 UTC, Ting-Wei Lan
none Details | Review
Remove libxkbcommon autogenargs (2.10 KB, patch)
2014-10-30 19:44 UTC, Ting-Wei Lan
none Details | Review
Remove libxkbcommon autogenargs - updated to work with current master branch (2.11 KB, patch)
2014-11-21 18:18 UTC, Ting-Wei Lan
none Details | Review
Remove libxkbcommon autogenargs - updated to work with current master branch (2.28 KB, patch)
2015-02-16 15:41 UTC, Ting-Wei Lan
none Details | Review
Remove libxkbcommon autogenargs - updated to include gnome-3.18 (3.19 KB, patch)
2015-04-21 05:59 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2014-09-03 18:39:16 UTC
Created attachment 285282 [details] [review]
Add FreeBSD-specific autogenargs for libxkbcommon

Default autogenargs passed to libxkbcommon causes gnome-shell to crash on FreeBSD ...
Comment 1 Allison Karlitskaya (desrt) 2014-09-21 17:41:28 UTC
I'm not a huge fan of hardcoding freebsd==/usr/local

I'd prefer if we could figure out a better way to do this (perhaps based on XDG datadir).  This might involve upstream changes or at least a patch.
Comment 2 Ting-Wei Lan 2014-10-28 17:31:55 UTC
Can we remove the autogenargs instead? Its configure script already uses `pkg-config --variable=xkb_base xkeyboard-config' to get the correct value.
Comment 3 Allison Karlitskaya (desrt) 2014-10-29 15:00:21 UTC
I'd be fine with that change if it is tested to work correctly on Linux.
Comment 4 Ting-Wei Lan 2014-10-30 19:44:33 UTC
Created attachment 289694 [details] [review]
Remove libxkbcommon autogenargs

I have tested this patch on Fedora 20 and FreeBSD 10.1.
Comment 5 Ting-Wei Lan 2014-11-13 12:30:38 UTC
Is the change acceptable now?
Comment 6 Ting-Wei Lan 2014-11-21 18:18:44 UTC
Created attachment 291196 [details] [review]
 Remove libxkbcommon autogenargs - updated to work with current master branch
Comment 7 Ting-Wei Lan 2015-02-16 15:41:17 UTC
Created attachment 296942 [details] [review]
Remove libxkbcommon autogenargs - updated to work with current master branch
Comment 8 Ting-Wei Lan 2015-04-21 05:59:33 UTC
Created attachment 302046 [details] [review]
Remove libxkbcommon autogenargs - updated to include gnome-3.18

I really hope we can push the patch because we have kept workaround in jhbuildrc for several months.
Comment 9 Ting-Wei Lan 2015-06-14 06:54:38 UTC
Attachment 302046 [details] pushed as 04fb017 - core-deps-3.14/3.16/3.18: Remove libxkbcommon autogenargs