After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735982 - [PATCH] Fix potential allocation of huge memory amount due to type overflow in src/lodepng.cpp
[PATCH] Fix potential allocation of huge memory amount due to type overflow i...
Status: RESOLVED FIXED
Product: doxygen
Classification: Other
Component: general
1.8.8-GIT
Other Linux
: Normal normal
: ---
Assigned To: Dimitri van Heesch
Dimitri van Heesch
Depends on:
Blocks:
 
 
Reported: 2014-09-03 17:35 UTC by Ettl Martin
Modified: 2014-12-25 16:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (785 bytes, patch)
2014-09-03 17:35 UTC, Ettl Martin 		none Details | Review

Description Ettl Martin 2014-09-03 17:35:13 UTC 
Created attachment 285274 [details] [review]
proposed fix

Please review the attached patch. It fixes coverity-scan id CID-50003. In src/lodepng.cpp the function ftell is called. In case of an error ftell returns the value -1. This return value is cached in a local variable and then it is used to allocate memory. If so, a huge amount of memory is allocated, because the -1 (int) is casted to (size_t)-max.

Best regards and many thanks

Martin Ettl
Comment 1 Dimitri van Heesch 2014-09-23 18:51:10 UTC 
Thanks, I'll include the patch in the next GIT update.
Comment 2 Dimitri van Heesch 2014-12-25 16:02:32 UTC 
This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.9. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information 
that you think can be relevant (preferrably in the form of a self-contained example).