After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735961 - Fix the back icons in RTL with newer GTK+
Fix the back icons in RTL with newer GTK+
Status: RESOLVED OBSOLETE
Product: gnome-sound-recorder
Classification: Other
Component: General
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-sound-recorder maintainer(s)
gnome-sound-recorder maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-03 11:09 UTC by Yosef Or Boczko
Modified: 2018-05-22 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Require gtk+ >= 3.13.2 (731 bytes, patch)
2014-09-03 11:10 UTC, Yosef Or Boczko 		none Details | Review
mainWindow.js: Fix the icons in RTL (1.87 KB, patch)
2014-09-03 11:11 UTC, Yosef Or Boczko 		none Details | Review
Removed old RTL hacks (2.21 KB, patch)
2016-09-19 22:22 UTC, Miguel Vaello Martínez 		none Details | Review

Description Yosef Or Boczko 2014-09-03 11:09:07 UTC 
Now GTK+ handle for us the RTL icons, so we needs to remove our
custom code for looking the RTL icons, otherwise we see 'fuzzy' icons
with newer version of GTK+.
Comment 1 Yosef Or Boczko 2014-09-03 11:10:51 UTC 
Created attachment 285246 [details] [review]
build: Require gtk+ >= 3.13.2
Comment 2 Yosef Or Boczko 2014-09-03 11:11:07 UTC 
Created attachment 285247 [details] [review]
mainWindow.js: Fix the icons in RTL

This is supported by GTK+ itself now.
Comment 3 Laurent Bigonville 2016-09-02 12:40:33 UTC 
The "let rtl = Gtk.Widget.get_default_direction() == Gtk.TextDirection.RTL;" par could probably be dropped too
Comment 4 Miguel Vaello Martínez 2016-09-19 22:22:18 UTC 
Created attachment 335878 [details] [review]
Removed old RTL hacks

All RTL code was removed because it gets retrieved automatically.
The code has been updated so that now the system recognizes
if RTL is necessary and loads the icons and other assests into
RTL with just one line of code.
Comment 5 GNOME Infrastructure Team 2018-05-22 12:55:32 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-sound-recorder/issues/13.