After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735950 - gdkpixbufdec: free query after use
gdkpixbufdec: free query after use
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-03 06:16 UTC by Vineeth
Modified: 2014-09-03 21:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (989 bytes, patch)
2014-09-03 06:17 UTC, Vineeth 		committed Details | Review

Description Vineeth 2014-09-03 06:16:31 UTC 
In gst_gdk_pixbuf_dec_setup_pool(), query is being allocated using 
 gst_query_new_allocation(), but the same is not unreferenced
 hence calling gst_query_unref() after usage of query.

Please review the same.
Comment 1 Vineeth 2014-09-03 06:17:54 UTC 
Created attachment 285223 [details] [review]
proposed patch
Comment 2 Tim-Philipp Müller 2014-09-03 21:38:44 UTC 
Thanks, pushed:

commit 8df9d690af8e30c6207799009f6cb7d169c56c1c
Author: Vineeth T M <vineeth.tm@samsung.com>
Date:   Wed Sep 3 11:46:13 2014 +0530

    gdkpixbufdec: free query after use
    
    In gst_gdk_pixbuf_dec_setup_pool(), query is being allocated using
    gst_query_new_allocation(), but the same is not unreferenced
    hence calling gst_query_unref() after usage of query.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=735950