After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735949 - Broken use of gdata_documents_service_get_primary_authorization_domain
Broken use of gdata_documents_service_get_primary_authorization_domain
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.13.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-03 02:14 UTC by Ankur Sinha (FranciscoD)
Modified: 2014-09-09 16:27 UTC
See Also:
GNOME target: ---
GNOME version: 3.13/3.14

Attachments
Fix use of gdata_documents_service_get_primary_authorization_domain (4.71 KB, patch)
2014-09-09 13:51 UTC, Debarshi Ray 		committed Details | Review

Description Ankur Sinha (FranciscoD) 2014-09-03 02:14:59 UTC 
I can click as much as I want, but it doesn't open them. On right clicking, a button that says "Open in Google documents" turns up in the bottom panel and this opens the document in FF, but otherwise, documents itself doesn't open a preview or anything.

Is this expected behaviour? I thought I'd used documents to view my google documents before. Not sure though, been a long time since I tried to access anything on google drive without a browser.

gnome-documents-3.13.4-3.fc21.x86_64
Comment 1 Bastien Nocera 2014-09-05 09:47:16 UTC 
Any errors on the command-line?
Comment 2 Ankur Sinha (FranciscoD) 2014-09-06 07:41:48 UTC 
(In reply to comment #1)
> Any errors on the command-line?

Yes. These come up every time I click on a google document to view it:

(gnome-documents:32354): Gjs-WARNING **: JS ERROR: TypeError: service.get_primary_authorization_domain is not a function
GoogleDocument<._createGDataEntry@/usr/share/gnome-documents/js/documents.js:767
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
GoogleDocument<.load@/usr/share/gnome-documents/js/documents.js:787
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
DocumentManager<.setActiveItem@/usr/share/gnome-documents/js/documents.js:1271
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
BaseManager<.setActiveItemById@/usr/share/gnome-documents/js/manager.js:92
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
ViewContainer<._onItemActivated@/usr/share/gnome-documents/js/view.js:339
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
start@/usr/share/gnome-documents/js/main.js:30
@<command line>:1
Comment 3 Ankur Sinha (FranciscoD) 2014-09-06 08:14:02 UTC 
gnome-documents-3.13.91-3.fc21.x86_64
gjs-1.41.91-1.fc21.x86_64
Comment 4 Bastien Nocera 2014-09-06 11:44:42 UTC 
Which version of libgdata is that? And don't forget to remove the NEEDINFO when you answer questions...
Comment 5 Ankur Sinha (FranciscoD) 2014-09-06 14:17:38 UTC 
libgdata-0.15.2-2.fc21.x86_64
Comment 6 Debarshi Ray 2014-09-08 15:49:29 UTC 
Looks like our use of gdata_documents_service_get_primary_authorization_domain API was broken all these years.

The C API is like this:
GDataAuthorizationDomain *
gdata_documents_service_get_primary_authorization_domain
                               (void);

But our use assumes something like:
GDataAuthorizationDomain *
gdata_documents_service_get_primary_authorization_domain
                               (GDataDocumentsService *service);

It is likely that the gjs/g-i stack became stricter in this regard.
Comment 7 Debarshi Ray 2014-09-09 13:51:46 UTC 
Created attachment 285742 [details] [review]
Fix use of gdata_documents_service_get_primary_authorization_domain
Comment 8 Cosimo Cecchi 2014-09-09 16:19:38 UTC 
Review of attachment 285742 [details] [review]:

Thanks Debarshi, looks good to me.
Comment 9 Debarshi Ray 2014-09-09 16:27:27 UTC 
Comment on attachment 285742 [details] [review]
Fix use of gdata_documents_service_get_primary_authorization_domain

Thanks for the review, Cosimo!