After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735871 - Improve SELinux support by introducing subdirs and by changing the order of the intermediate file locations
Improve SELinux support by introducing subdirs and by changing the order of t...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: orc
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-02 08:51 UTC by Fabian Deutsch
Modified: 2018-11-03 10:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-Use-a-subdirectory-for-temporary-files.patch (1.55 KB, patch)
2014-09-02 08:51 UTC, Fabian Deutsch
needs-work Details | Review
0002-TMPDIR-becomes-the-last-option.patch (1.63 KB, patch)
2014-09-02 08:52 UTC, Fabian Deutsch
committed Details | Review
0003-Add-compiler-option-for-ENABLE_USER_CODEMEM.patch (2.27 KB, patch)
2014-09-02 08:52 UTC, Fabian Deutsch
needs-work Details | Review

Description Fabian Deutsch 2014-09-02 08:51:27 UTC
This bug also exists here:
https://bugs.freedesktop.org/show_bug.cgi?id=41446

To help writing selinux rules for orc two changes are introduced:

1. Use a subdir for intermediate files
2. Change the order of potential locations for the intermediate files

The attached patches add this functionality.
Comment 1 Fabian Deutsch 2014-09-02 08:51:59 UTC
Created attachment 285118 [details] [review]
0001-Use-a-subdirectory-for-temporary-files.patch
Comment 2 Fabian Deutsch 2014-09-02 08:52:34 UTC
Created attachment 285119 [details] [review]
0002-TMPDIR-becomes-the-last-option.patch
Comment 3 Fabian Deutsch 2014-09-02 08:52:48 UTC
Created attachment 285120 [details] [review]
0003-Add-compiler-option-for-ENABLE_USER_CODEMEM.patch
Comment 4 Sebastian Dröge (slomo) 2014-09-04 08:37:05 UTC
Review of attachment 285118 [details] [review]:

::: orc/orccodemem.c
@@ +204,3 @@
+
+  dir = malloc (strlen (basedir) + strlen ("/orc") + 1);
+  sprintf (dir, "%s/orc", basedir);

This is not portable as it uses "/" as a path separator always.
Comment 5 Sebastian Dröge (slomo) 2014-09-04 08:39:08 UTC
Comment on attachment 285120 [details] [review]
0003-Add-compiler-option-for-ENABLE_USER_CODEMEM.patch

Use AC_DEFINE() and config.h for this.
Comment 6 Sebastian Dröge (slomo) 2014-09-04 08:40:02 UTC
Comment on attachment 285119 [details] [review]
0002-TMPDIR-becomes-the-last-option.patch

commit 0e31d7fc6a03faf1076dfd51b49401539c3ebed9
Author: Fabian Deutsch <fabiand@fedoraproject.org>
Date:   Tue Sep 2 10:38:17 2014 +0200

    TMPDIR becomes the last option
    
    Previously $TMPDIR and /tmp were the first options to try to use for
    intermediate files. To prevent name collisions, now user specific dirs ($HOME
    and $XDG_RUNTIME_DIR) are prefered over the user unspecific dirs ($TMP and
    /tmp).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=735871
Comment 7 GStreamer system administrator 2018-11-03 10:46:55 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/orc/issues/1.