GNOME Bugzilla – Bug 735858
Extra space in sidebar
Last modified: 2014-09-04 18:59:01 UTC
As of commit 09becd6 ("Have sidebar push the map on reveal"), the route search form has some extra white-space on the right and the route mode buttons looks weirdly aligned. My guess is that it's because an extra column was added in the grid somehow. I can't really see it from the diff though. I'll attach before and after screens to show what I mean.
Created attachment 285107 [details] Before
Created attachment 285108 [details] After
Created attachment 285225 [details] [review] sidebar: Grow route entries I have attempted some fixes for this. What do you think?
Created attachment 285226 [details] Before patch
Created attachment 285227 [details] After patch
Btw, should the 'via' entries have the end-symbolic icon as well?
Created attachment 285267 [details] After patch (more margin) Thanks Jonas, Actually the patch looks good to me, but I would prefer more separation between button/image and the border of the sidebar. It look like buttons are more close to the sidebar border than to the entry, although the distances are the same, we need to be sure that the distance are closer to the entry than to the border, so the button looks more related to the entry. Same happens to the image. This image is your patch applied with some tweaked margin values. What do you think? (In reply to comment #6) > Btw, should the 'via' entries have the end-symbolic icon as well? I think yes, let ask to Dario/Andreas, and maybe adding the icons help us to do less hacks to keep entries well aligned.
(In reply to comment #7) > Created an attachment (id=285267) [details] > After patch (more margin) > > Thanks Jonas, > > Actually the patch looks good to me, but I would prefer more separation between > button/image and the border of the sidebar. > > It look like buttons are more close to the sidebar border than to the entry, > although the distances are the same, we need to be sure that the distance are > closer to the entry than to the border, so the button looks more related to the > entry. > > Same happens to the image. > > This image is your patch applied with some tweaked margin values. What do you > think? Thanks for review! I think looks good, what margin values did you use? > > (In reply to comment #6) > > Btw, should the 'via' entries have the end-symbolic icon as well? > > I think yes, let ask to Dario/Andreas, and maybe adding the icons help us to do > less hacks to keep entries well aligned. Yeah would like to hear from Andreas. But could be done as a separate bug.
Created attachment 285280 [details] [review] sidebar: Grow route entries This is the modified Jonas's patch with the tweaked margins, I also used margin in one side for placeholder widgets like to-placeholder-grid and via-image.