After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735857 - Extracting (by drag & drop) causes an error when the mouse is hovering Chromium
Extracting (by drag & drop) causes an error when the mouse is hovering Chromium
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal major
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-02 01:14 UTC by William Di Luigi
Modified: 2015-05-19 05:28 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description William Di Luigi 2014-09-02 01:14:59 UTC
1) Open chromium fullscreen
2) Open nautilus
3) Open an archive with file-roller
4) Try to drag & drop a file (inside the archive) to nautilus (without hovering chromium). It should work.
5) If, instead, you hover chromium, a pop-up will appear (within file-roller) with the following error:

    Destination folder "(null)" does not exist.
    Do you want to create it?
    (Cancel) (Create folder)

If I click on (Cancel), another (narrow, but very tall) pop-up appears:

    Extraction not performed
    (Close)
Comment 1 Eric Koegel 2014-11-30 07:16:43 UTC
I'm seeing the same error when going over xfdesktop 4.10.3 after the change to xfdesktop in this commit: http://git.xfce.org/xfce/xfdesktop/commit/?h=xfce-4.10&id=d3b69780a14d9991c395233a14227706e3990a7a

The change is that in xfdesktop_icon_view_drag_motion it calls gtk_drag_get_data instead of gdk_drag_status and defers that call to xfdesktop_icon_view_drag_data_received, as in:
http://git.xfce.org/xfce/xfdesktop/tree/src/xfdesktop-icon-view.c?h=xfce-4.10#n1452

The GTK docs say we can do it this way: https://developer.gnome.org/gtk2/2.24/GtkWidget.html#GtkWidget-drag-motion
"If the decision whether the drop will be accepted or rejected can't be made based solely on the cursor position and the type of the data, the handler may inspect the dragged data by calling gtk_drag_get_data() and defer the gdk_drag_status() call to the “drag-data-received” handler."

Additionally, Bug 740233 looks to be similar to this one.
Comment 2 Paolo Bacchilega 2015-02-15 12:30:46 UTC
this should be fixed now in master, test please !
Comment 3 Evangelos Foutras 2015-02-15 16:14:37 UTC
(In reply to Paolo Bacchilega from comment #2)
> this should be fixed now in master, test please !

Yup, it's fixed in commit af95f7d. You're probably going to do this anyway, but please apply the fix to the "gnome-3-14" branch as well! :)

As far as I can see, both this and bug 740233 are caused by the same issue and are now resolved.
Comment 4 Paolo Bacchilega 2015-02-15 17:15:42 UTC
Pushed to gnome-3-14 as well.
Comment 5 Teemu Kauhanen 2015-05-19 05:28:49 UTC
Bug is still apparent in 3.14.1-1
https://packages.debian.org/source/jessie/file-roller
https://packages.debian.org/source/sid/file-roller

One would expect fix to be already in sid debian repository? but sid and jessie version number look the same.