After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735832 - flacdec: merge small decoded audio buffers
flacdec: merge small decoded audio buffers
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-01 17:31 UTC by Vincent Penquerc'h
Modified: 2014-10-30 12:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flacdec: merge small decoded audio buffers (4.23 KB, patch)
2014-09-01 17:31 UTC, Vincent Penquerc'h 		rejected Details | Review

Description Vincent Penquerc'h 2014-09-01 17:31:40 UTC 
Created attachment 285041 [details] [review]
flacdec: merge small decoded audio buffers

FLAC files with high bitrate and small block sizes cause large amounts of data to be sent in small buffers, causing unnecessary CPU use.
This patch merges decoded output if the buffers are less than 20 ms (hardcoded here).

It breaks the expectation that there is a buffer out for a buffer in, however, which may be unwanted.
Comment 1 Tim-Philipp Müller 2014-09-01 17:44:30 UTC 
In this scenario do you get multiple flac frames as input in one single buffer?
Comment 2 Sebastian Dröge (slomo) 2014-09-02 06:39:30 UTC 
Comment on attachment 285041 [details] [review]
flacdec: merge small decoded audio buffers

Also this should probably be handled by the GstAudioDecoder base class. It already has code for that in gst_audio_decoder_output()
Comment 3 Tim-Philipp Müller 2014-09-02 08:22:22 UTC 
(The reason for my question was latency btw).
Comment 4 Vincent Penquerc'h 2014-09-02 09:20:28 UTC 
(In reply to comment #1)
> In this scenario do you get multiple flac frames as input in one single buffer?

Logs show one buffer sent to flacdec for each FLAC frame.
Comment 5 Vincent Penquerc'h 2014-10-30 12:11:54 UTC 
This is invalid, since the ability actually already exists in the base class.