After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735825 - Rework adwaita gtk2 theme
Rework adwaita gtk2 theme
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK2 theme
unspecified
Other Linux
: Normal critical
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-01 16:58 UTC by Trinh Anh Ngoc
Modified: 2014-09-23 22:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (873.67 KB, image/png)
2014-09-01 16:58 UTC, Trinh Anh Ngoc 		  Details
gtk2: integrate improvements from atw1990@gmail.com (64.02 KB, patch)
2014-09-18 06:19 UTC, Cosimo Cecchi 		committed Details | Review
Geany (63.49 KB, image/png)
2014-09-22 17:24 UTC, Trinh Anh Ngoc 		  Details
GIMP (160.26 KB, image/png)
2014-09-22 17:25 UTC, Trinh Anh Ngoc 		  Details
Goldendict (72.52 KB, image/png)
2014-09-22 17:25 UTC, Trinh Anh Ngoc 		  Details
QtCreator (93.18 KB, image/png)
2014-09-22 17:26 UTC, Trinh Anh Ngoc 		  Details

Description Trinh Anh Ngoc 2014-09-01 16:58:59 UTC 
Created attachment 285035 [details]
Screenshot

Hello GNOME guys. Many popular apps on linux using gtk2 scheme for render as libreoffice (vlc), firefox (xul), goldendict (qt), codeblock (wx),... In these apps, Entry, ComboBox, SpinButton,... look ugly on Gnome Shell. I worked on this and fixed almost issues. Look screenshot for details. Seem adwaita gtk2 is unfit with default Cantarell font, better with DejaVu Sans 10.

https://github.com/20115681/adwaita-gtk2
Comment 1 Cosimo Cecchi 2014-09-18 06:16:05 UTC 
Thank you so much - this looks really good. I made a patch with the non-whitespace changes, and I will commit it after hard code freeze is over.
Comment 2 Cosimo Cecchi 2014-09-18 06:19:28 UTC 
Created attachment 286442 [details] [review]
gtk2: integrate improvements from atw1990@gmail.com

--

Rebased and cleaned up against HEAD
Comment 3 Trinh Anh Ngoc 2014-09-22 17:23:54 UTC 
Notebook background is one of problems that cause above issues. I redesigned notebook and theme is perfect with both GTK and QT,...now. Sceenshots attached. Check my github and make new patch again. Thank you :)
Comment 4 Trinh Anh Ngoc 2014-09-22 17:24:32 UTC 
Created attachment 286829 [details]
Geany
Comment 5 Trinh Anh Ngoc 2014-09-22 17:25:10 UTC 
Created attachment 286830 [details]
GIMP
Comment 6 Trinh Anh Ngoc 2014-09-22 17:25:39 UTC 
Created attachment 286831 [details]
Goldendict
Comment 7 Trinh Anh Ngoc 2014-09-22 17:26:06 UTC 
Created attachment 286832 [details]
QtCreator
Comment 8 Jakub Steiner 2014-09-23 22:00:38 UTC 
Comment on attachment 286442 [details] [review]
gtk2: integrate improvements from atw1990@gmail.com

Attachment 286442 [details] pushed as a3c7649 - gtk2: integrate improvements from atw1990@gmail.com
Comment 9 Jakub Steiner 2014-09-23 22:01:09 UTC 
updated radios and checkboxes a little and pushed. Thanks for the patch.