After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735809 - Only export symbols starting with 'e_' in libebook-contacts
Only export symbols starting with 'e_' in libebook-contacts
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
3.12.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2014-09-01 13:13 UTC by Laurent Bigonville
Modified: 2014-09-08 13:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Only export symbols starting with 'e_' in libebook-contacts-1.2 (1.02 KB, patch)
2014-09-01 15:55 UTC, Laurent Bigonville 		needs-work Details | Review

Description Laurent Bigonville 2014-09-01 13:13:14 UTC 
Hello,

When compiling eds with libphonenumbers support, I've new exported symbols in the libebook-contacts-1.2-0 library:

+ _ZN4i18n12phonenumbers10NullLogger12WriteMessageERKSs@Base 3.12.5-2
+ _ZN4i18n12phonenumbers10NullLoggerD0Ev@Base 3.12.5-2
+ _ZN4i18n12phonenumbers10NullLoggerD1Ev@Base 3.12.5-2
+ _ZN4i18n12phonenumbers10NullLoggerD2Ev@Base 3.12.5-2
+ _ZN4i18n12phonenumbers6Logger10WriteLevelEv@Base 3.12.5-2
+ _ZTIN4i18n12phonenumbers10NullLoggerE@Base 3.12.5-2
+ _ZTIN4i18n12phonenumbers6LoggerE@Base 3.12.5-2
+ _ZTSN4i18n12phonenumbers10NullLoggerE@Base 3.12.5-2
+ _ZTSN4i18n12phonenumbers6LoggerE@Base 3.12.5-2
+ _ZTVN4i18n12phonenumbers10NullLoggerE@Base 3.12.5-2
+ _ZTVN4i18n12phonenumbers6LoggerE@Base 3.12.5-2

I guess these shouldn't be exported?
Comment 1 Laurent Bigonville 2014-09-01 15:08:58 UTC 
I guess -export-symbols-regex should be used to restrict the exported symbols?
Comment 2 Laurent Bigonville 2014-09-01 15:55:16 UTC 
Created attachment 285029 [details] [review]
Only export symbols starting with 'e_' in libebook-contacts-1.2

Add -export-symbols-regex "^e_.*" the LDFLAGS of libebook-contacts-1.2
to avoid extra symbols to be exported when building with libphonenumber
support
Comment 3 Milan Crha 2014-09-08 13:11:56 UTC 
Review of attachment 285029 [details] [review]:

Thanks for the patch, I'll just fix the typo in it and commit it.

::: addressbook/libebook-contacts/Makefile.am
@@ +62,3 @@
 libebook_contacts_1_2_la_LDFLAGS = \
 	-version-info $(LIBEBOOK_CONTACTS_CURRENT):$(LIBEBOOK_CONTACTS_REVISION):$(LIBEBOOK_CONTACTS_AGE) $(NO_UNDEFINED) \
+	-export-symbols-regex "^e_.*"

There is missing " \" at the end, to have the rest of the arguments included in LDFLAGS
Comment 4 Milan Crha 2014-09-08 13:14:33 UTC 
Created commit 030e72c in eds master (3.13.6+) [1]

[1] https://git.gnome.org/browse/evolution-data-server/commit/?id=030e72c