GNOME Bugzilla – Bug 735721
Missing some RTL icons
Last modified: 2015-09-01 08:29:32 UTC
I see the following symbolic: media-playback-start-rtl-symbolic media-playback-start-symbolic media-playback-start-symbolic-rtl The first one, 'media-playback-start-rtl-symbolic' needs to be removed. media-seek-backward-rtl-symbolic media-seek-backward-symbolic media-seek-forward-rtl-symbolic media-seek-forward-symbolic We needs here media-seek-backward-symbolic-rtl and media-seek-forward-symbolic-rtl. The one with -rtl before -symbolic needs to be removed. media-skip-backward-rtl-symbolic media-skip-backward-symbolic media-skip-forward-rtl-symbolic media-skip-forward-symbolic The same here: we needs -rtl suffix after the -symbolic, not before it. I not sure, but maybe we needs also -ltr suffix for evry file with -rtl one?
yes, the order we look for is -symbolic-rtl no, -ltr is not needed
Created attachment 285147 [details] [review] Symbolic: proper rtl variants for media icons
Attachment 285147 [details] pushed as 03f238c - Symbolic: proper rtl variants for media icons
I found a few ones more that look like they need to move the -rtl part around: Adwaita/scalable/actions/format-text-direction-rtl-symbolic.svg Adwaita/scalable/status/media-playlist-consecutive-rtl-symbolic.svg Adwaita/scalable/status/media-playlist-repeat-song-rtl-symbolic.svg Adwaita/scalable/status/media-playlist-repeat-rtl-symbolic.svg Adwaita/scalable/status/media-playlist-shuffle-rtl-symbolic.svg Adwaita/scalable/status/semi-starred-rtl-symbolic.svg Also, another one that needs to drop the -ltr part, according to comment #1: Adwaita/scalable/actions/format-text-direction-ltr-symbolic.svg
Created attachment 308896 [details] [review] Patch proposal This should do it, please review. Thanks!
Ping?
Thanks for applying it, Jakub