GNOME Bugzilla – Bug 735710
[PATCH] Add <ctrl>N shortcut.
Last modified: 2014-09-04 21:39:13 UTC
Created attachment 284883 [details] [review] Add <ctrl>N shortcut. I think that, even if <alt>N works, the <ctrl>N shortcut should be used to go to the new-game screen. It’s a standard shortcut, the other isn’t discoverable with actual Gtk+ settings, there’s already <ctrl>Z, etc. Maybe we should set another <ctrl> shortcut for clearing board, and get rid with the <alt> key?
(In reply to comment #0) > I think that, even if <alt>N works, the <ctrl>N shortcut should be used to go > to the new-game screen. Yes! > Maybe we should set another <ctrl> shortcut for clearing board Maybe! > and get rid with the <alt> key? No! There is a difference here. The <ctrl> shortcuts are what we call "accelerators" -- they're associated with a GAction of either the GtkApplication or the GtkApplicationWindow. The <alt> shortcuts are "mnenmonics" or "access keys" that are associated with particular user interface elements -- in this case, the buttons on the window. You can see mnemonics by holding down Alt. All text buttons should have mnemonics.
Created attachment 284897 [details] [review] Add <ctrl>N and <ctrl>C shortcuts. No problem to have mnemonics, as long as I don’t have to deal with them. Here is a patch with the two shortcuts.
Mh, in fact, I’m not sure. <ctrl>C or <ctrl>R? The two would make sense…
I haven't seen the use of Ctrl+C for resetting something. Whenever I think about this shortcut, it's about either SIGINT, or copy text. Ctrl+R seems more appropriate. (Reset, Refresh, ...) but no strong opinion :-)
Created attachment 285014 [details] [review] Add <ctrl>N and <ctrl>R shortcuts. More usual with <ctrl>R, yeah.
Thanks! Attachment 285014 [details] pushed as 44e487e - Add <ctrl>N and <ctrl>R shortcuts.